Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Fixed integ test python syntx warning #12996

Conversation

VinashakAnkitAman
Copy link
Member

Title

fix(agw): Fixed integ test python syntax warning

Summary

On latest master, a warning is thrown for every test case for wrong python syntax during comparison of byte string. This PR fixes the python syntax warning in CI.

Following is the warning:

/home/vagrant/magma/lte/gateway/python/integ_tests/s1aptests/util/traffic_messages.py:149: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(length) and length is not b'0':

Test plan

Verified with sanity

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 15, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Jun 15, 2022
@mpfirrmann
Copy link
Contributor

This code change is already part of #12938

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

feg-workflow

    2 files  203 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 0ea35fe.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

dp-workflow

18 tests   18 ✔️  4m 54s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit 0ea35fe.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

agw-workflow

     79 files     124 suites   6m 41s ⏱️
1 153 tests 1 149 ✔️ 4 💤 0
1 155 runs  1 151 ✔️ 4 💤 0

Results for commit 0ea35fe.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pruthvihebbani
Copy link
Contributor

lte test job is failing. Can you check

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pruthvihebbani pruthvihebbani merged commit 8f07937 into magma:master Jun 16, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Jun 16, 2022
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants