Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): cache Vagrant boxes with Github Actions Cache #13003

Merged
merged 1 commit into from Jun 16, 2022

Conversation

jheidbrink
Copy link
Contributor

Summary

The Github Actions workflows see a lot of HTTP 429 when downloading Vagrant boxes from the Vagrant Cloud.

As a quick fix, simply cache the ~/.vagrant.d/boxes directory using the actions/cache action.

Test Plan

Spin up the magma_dev, magma_test and magma_trfserver VMs and verify the cache is used: https://github.com/jheidbrink/magma/actions/runs/2507266285

Additional Information

  • This change is backwards-breaking

All our boxes (lte, cwf) currently use around 8 GiB of disk space. That is close to the cache size limit of 10GiB. Given that we don't use the Github Actions caches elsewhere and don't regularly update the boxes, this should be ok for now. Once the boxes receive more regular upgrades, we need to find a more elaborate solution.

@jheidbrink jheidbrink requested a review from a team June 16, 2022 07:11
@jheidbrink jheidbrink requested a review from a team as a code owner June 16, 2022 07:11
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 16, 2022
Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - discussed offline

@github-actions
Copy link
Contributor

dp-workflow

18 tests   18 ✔️  4m 54s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit b54aad3.

@jheidbrink jheidbrink enabled auto-merge (squash) June 16, 2022 08:12
@jheidbrink jheidbrink merged commit d92d0a5 into magma:master Jun 16, 2022
@jheidbrink jheidbrink deleted the cache_vagrant_boxes branch June 27, 2022 16:02
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants