Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix Bazel failure Slack message in agw-workflow #13005

Merged
merged 1 commit into from Jun 16, 2022

Conversation

vktng
Copy link
Contributor

@vktng vktng commented Jun 16, 2022

Summary

The failure reporting step was not triggered on failure. We have to still include failure() to override the default status check of success() that is automatically applied to if conditions that don't contain a status check function.

Test Plan

CI.
Also tested on fork: https://github.com/vktng/magma/runs/6917739513?check_suite_focus=true

Additional Information

  • This change is backwards-breaking

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
@vktng vktng added the bazel changes for the Bazelification effort label Jun 16, 2022
@vktng vktng requested a review from nstng June 16, 2022 12:09
@vktng vktng requested a review from a team as a code owner June 16, 2022 12:09
@vktng vktng self-assigned this Jun 16, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 16, 2022
@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice to figure out that success() is added implicitly 👍

@nstng nstng enabled auto-merge (squash) June 16, 2022 12:32
@github-actions
Copy link
Contributor

dp-workflow

18 tests   18 ✔️  4m 33s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit fe1214a.

@github-actions
Copy link
Contributor

agw-workflow

     79 files     124 suites   6m 46s ⏱️
1 153 tests 1 149 ✔️ 4 💤 0
1 155 runs  1 151 ✔️ 4 💤 0

Results for commit fe1214a.

@nstng nstng merged commit e874b12 into magma:master Jun 16, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants