fix(dp): Fix typo in domain-proxy Makefile

[sklgromek]

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Summary

Fix typo iuntroduced by #12999

Test Plan

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

dp-workflow

18 tests   18 ✔️  5m 4s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit 51d3ae8.

♻️ This comment has been updated with latest results.

[xbend]

@magma/approvers-ci
Please review and approve the changes in this PR. It fixes master CI runs, and since the dp workflow will soon be made a required CI job, it's pretty urgent we get this into master.

[maxhbr]

this reverts the change suggested in #12855 (comment). Can you elaborate why this was done? I think @Neudrino had some reason for his suggestion

[xbend]

The suggestion was to use the pull_request_target trigger action to make secrets available. We took the advice without actually verifying the validity of the suggestion.
pull_request_target is documented as follows:

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow. This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

We are building code from the pull request, as that is the whole idea of running integration tests.

Secondly, the only secret we use is the GITHUB_TOKEN which is an exception to availability of secrets in PRs from forks:

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Now, since we have introduced the pull_request_target, the CI was run from the base of the PRs, rather from the head of the PR branch, and that hid the mistake in the Makefile.

[maxhbr]

The changes look good, just the pull_request_target -> pull_request change is not explained

[maxhbr]

LGTM