Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): Fix settings link on host portal #13027

Merged

Conversation

thmsschmitt
Copy link
Contributor

Summary

The link to the account settings is broken on host portal.

Test Plan

Check that account settings can be opened form:

  • the host portal
  • the nms portal with a network
  • the nms portal without a network
    Screenshot 2022-06-20 at 12 57 31

Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jun 20, 2022
@github-actions
Copy link
Contributor

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 35866f9.

@thmsschmitt thmsschmitt marked this pull request as ready for review June 20, 2022 11:14
@thmsschmitt thmsschmitt requested review from a team, andreilee and Neudrino and removed request for andreilee June 20, 2022 11:14
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked deployment from branch. Can successfully load the page in question.

@thmsschmitt thmsschmitt merged commit 68e0eb8 into magma:master Jun 20, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants