Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): bazel coverage failures are mitigated by several flags (see #13026) #13028

Merged
merged 1 commit into from Jun 20, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Jun 20, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

see #13026

Test Plan

  • setup remote caching with rw locally
  • execute bazel coverage lte/gateway/c/session_manager/test/...
    • see that bazel-out/_coverage/_coverage_report.dat is (ok) or is not (failure) generated
    • do bazel clean between runs
    • you may need multiple runs to see that coverage is not generated
  • execute bazel coverage --experimental_split_coverage_postprocessing --experimental_fetch_all_coverage_outputs --remote_download_outputs=all lte/gateway/c/session_manager/test/...
    • see that coverage is always generated

Additional Information

  • This change is backwards-breaking

…agma#13026)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng added the bazel changes for the Bazelification effort label Jun 20, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 20, 2022
@nstng nstng linked an issue Jun 20, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

dp-workflow

18 tests   18 ✔️  4m 25s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit cd1337d.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2022

agw-workflow

     79 files     124 suites   6m 56s ⏱️
1 153 tests 1 149 ✔️ 4 💤 0
1 155 runs  1 151 ✔️ 4 💤 0

Results for commit cd1337d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (but difficult to know for sure - without the change I had 1 failure in 6 runs)

@nstng nstng marked this pull request as ready for review June 20, 2022 19:19
@nstng nstng requested a review from a team as a code owner June 20, 2022 19:19
@nstng nstng merged commit 16758fc into magma:master Jun 20, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…agma#13026) (magma#13028)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel coverage in CI is resolved
3 participants