Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary usage of deadsnakes ppa #13045

Merged
merged 1 commit into from Jun 22, 2022

Conversation

sebathomas
Copy link
Contributor

Summary

Python 3.8 is the default version in Ubuntu focal, it's not necessary to get it from a ppa.

Test Plan

CI

Additional Information

  • This change is backwards-breaking

Python 3.8 is the default version in Ubuntu focal, it's not
necessary to get it from a ppa.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 21, 2022
@github-actions github-actions bot added component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels Jun 21, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

feg-workflow

    2 files  203 suites   38s ⏱️
371 tests 371 ✔️ 0 💤 0
385 runs  385 ✔️ 0 💤 0

Results for commit 4c9a765.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

dp-workflow

18 tests   18 ✔️  4m 22s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit 4c9a765.

@github-actions
Copy link
Contributor

cloud-workflow

982 tests   982 ✔️  2m 12s ⏱️
355 suites      0 💤
    7 files        0

Results for commit 4c9a765.

@github-actions
Copy link
Contributor

agw-workflow

     79 files     124 suites   6m 41s ⏱️
1 154 tests 1 150 ✔️ 4 💤 0
1 156 runs  1 152 ✔️ 4 💤 0

Results for commit 4c9a765.

@sebathomas sebathomas marked this pull request as ready for review June 21, 2022 15:16
@sebathomas sebathomas requested review from a team and emakeev June 21, 2022 15:16
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebathomas sebathomas merged commit f536499 into magma:master Jun 22, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Python 3.8 is the default version in Ubuntu focal, it's not
necessary to get it from a ppa.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants