Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update references to Go version from 1.18 to 1.18.3 #13107

Merged
merged 1 commit into from Jul 7, 2022

Conversation

voisey
Copy link
Contributor

@voisey voisey commented Jun 28, 2022

Summary

Note: To merge alongside #13046

Updates the Prerequisites page so that users download the correct Go version.

Test Plan

  • cd magma/docs && make precommit

@voisey voisey requested review from a team and Neudrino June 28, 2022 13:30
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Jun 28, 2022
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: To merge alongside #13046

Ok for now, but usually this should be cherry picked in #13046 than, such that no coordinated merges are necessary.

@voisey voisey added the DONOTLAND Please don't merge this label Jun 28, 2022
@voisey
Copy link
Contributor Author

voisey commented Jun 28, 2022

Note: To merge alongside #13046

Ok for now, but usually this should be cherry picked in #13046 than, such that no coordinated merges are necessary.

True! I considered this once I had made the PR. I'm also happy for it to be cherry picked if preferable. cc @sebathomas

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@sebathomas sebathomas merged commit f0f3c29 into magma:master Jul 7, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue DONOTLAND Please don't merge this size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants