Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): Add recipe for running AGW containers locally #13137

Merged
merged 1 commit into from Jun 29, 2022

Conversation

jheidbrink
Copy link
Contributor

@jheidbrink jheidbrink commented Jun 29, 2022

Summary

Provide a recipe for running the AGW containers locally.

Test Plan

Looked at the container logs and verified things look "mostly good" (some things fail like magmad invoking systemd to query stats of other services, but fixing that is a different task)

I did not run an integ test on this deployment, nor used one of our CLIs to verify functionality.

Additional Information

  • This change is backwards-breaking

@jheidbrink jheidbrink requested a review from a team June 29, 2022 16:50
@jheidbrink jheidbrink requested a review from a team as a code owner June 29, 2022 16:50
@jheidbrink jheidbrink requested a review from Neudrino June 29, 2022 16:50
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 29, 2022
@jheidbrink jheidbrink force-pushed the run_agwc_locally_on_magma_vm branch from 0fe14b6 to a1f8df1 Compare June 29, 2022 16:51
Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
@jheidbrink jheidbrink force-pushed the run_agwc_locally_on_magma_vm branch from a1f8df1 to 0ac3496 Compare June 29, 2022 16:52
@Neudrino Neudrino enabled auto-merge (squash) June 29, 2022 16:54
@magma magma deleted a comment from github-actions bot Jun 29, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 0ac3496.

@github-actions
Copy link
Contributor

dp-workflow

18 tests   18 ✔️  4m 11s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit 0ac3496.

@Neudrino Neudrino merged commit a5093ae into magma:master Jun 29, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants