Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(orc8r): Adds how-to guide for deploying orc8r with Juju #13161

Merged
merged 1 commit into from Jul 5, 2022
Merged

docs(orc8r): Adds how-to guide for deploying orc8r with Juju #13161

merged 1 commit into from Jul 5, 2022

Conversation

gruyaume
Copy link
Contributor

@gruyaume gruyaume commented Jun 30, 2022

Summary

This PR contains the same code as #13008.
Adds documentation to deploy orc8r using Juju.

@gruyaume gruyaume requested review from a team and Neudrino June 30, 2022 16:34
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jun 30, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Jun 30, 2022
@gruyaume
Copy link
Contributor Author

This PR contains the same code as #13008. @maxhbr @voisey

@maxhbr
Copy link
Member

maxhbr commented Jun 30, 2022

just saw that the table does not seem to render correctly:
2022-06-30_18-37-28

@gruyaume
Copy link
Contributor Author

just saw that the table does not seem to render correctly: 2022-06-30_18-37-28

This should be fixed now.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

Oops! Looks like you failed the Markdown lint check.

Howto

♻️ Updated: ✅ The check is passing the Markdown lint check after the last commit.

@Neudrino
Copy link
Contributor

Neudrino commented Jul 1, 2022

Looks good in general. We should make the linters happy before merge.
FYI: https://docs.magmacore.org/docs/next/docs/docs_overview#howto

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

@voisey
Copy link
Contributor

voisey commented Jul 4, 2022

Hi @gruyaume, thanks for this. It seems your last commit is missing the sign off - could you please add this and rebase while doing so? Then I think we can merge 🙂

@gruyaume
Copy link
Contributor Author

gruyaume commented Jul 4, 2022

Hi @gruyaume, thanks for this. It seems your last commit is missing the sign off - could you please add this and rebase while doing so? Then I think we can merge slightly_smiling_face

Should be fixed now, hopefully...

@maxhbr
Copy link
Member

maxhbr commented Jul 4, 2022

Sorry to be annoying, but Check Rebase is red and that prevents merge, can you please rebase ;)

@gruyaume gruyaume requested a review from a team as a code owner July 4, 2022 12:39
@gruyaume gruyaume requested review from a team July 4, 2022 12:39
@gruyaume gruyaume requested a review from a team as a code owner July 4, 2022 12:39
@gruyaume gruyaume requested review from a team July 4, 2022 12:39
@gruyaume gruyaume requested a review from a team as a code owner July 4, 2022 12:39
@gruyaume gruyaume requested review from a team July 4, 2022 12:39
.devcontainer/bazel-base/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/bazel-base/Dockerfile Outdated Show resolved Hide resolved
cwf/gateway/docker/go/Dockerfile Outdated Show resolved Hide resolved
cwf/gateway/docker/go/Dockerfile Outdated Show resolved Hide resolved
feg/gateway/docker/go/Dockerfile Outdated Show resolved Hide resolved
feg/gateway/docker/go/Dockerfile Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/XXL Denotes a Pull Request that changes 1000+ lines. labels Jul 4, 2022
@github-actions github-actions bot added component: docs Documentation-related issue and removed component: cwf component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Jul 4, 2022
@sebathomas sebathomas removed request for a team July 4, 2022 12:44
@gruyaume
Copy link
Contributor Author

gruyaume commented Jul 4, 2022

Sorry to be annoying, but Check Rebase is red and that prevents merge, can you please rebase ;)

Sure I just rebased and now this PR contains 95 commits (still only my 3 files changed though). I'm not sure if this was the expected behaviour.

@sebathomas
Copy link
Contributor

Normally, this shouldn't happen. Maybe you accidentally merged instead of rebasing? Why do you get the commit "Merge remote-tracking branch 'origin/dev-juju' into dev-juju"?

@gruyaume
Copy link
Contributor Author

gruyaume commented Jul 5, 2022

Normally, this shouldn't happen. Maybe you accidentally merged instead of rebasing? Why do you get the commit "Merge remote-tracking branch 'origin/dev-juju' into dev-juju"?

Yeah I managed to fix this, thank you!

@voisey voisey enabled auto-merge (squash) July 5, 2022 06:07
@voisey
Copy link
Contributor

voisey commented Jul 5, 2022

Thanks for fixing this @gruyaume! I've set auto-merge so this will get merged once the Jenkins job passes

@voisey voisey merged commit 1a71dbe into magma:master Jul 5, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: guillaume <guillaume.belanger27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants