chore: Ansible warnings are fixed #13165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
mpfirrmann
changed the title
ajahl
approved these changes
Jul 2, 2022
sebathomas
approved these changes
Jul 4, 2022
voisey
approved these changes
Jul 4, 2022
mpfirrmann
force-pushed
the
depr_warning_ansible
branch
from
8486045
to
092d2f8
Compare
themarwhal
approved these changes
Jul 12, 2022
mpfirrmann
force-pushed
the
depr_warning_ansible
branch
from
092d2f8
to
5d05856
Compare
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
mpfirrmann
force-pushed
the
depr_warning_ansible
branch
from
5d05856
to
824c689
Compare
crasu
approved these changes
Jul 25, 2022
mpfirrmann
added
the
ready2merge
MoritzThomasHuebner
pushed a commit
to MoritzThomasHuebner/magma
that referenced
this pull request
Jul 26, 2022
* 'callback_whitelist' warnings are removed * 'append' warning is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* 'callback_whitelist' warnings are removed * 'append' warning is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two different deprecation warnings in the Ansible playbooks / configs are taken care of.
callback_whitelistis deprecated and replaced bycallbacks_enabled; https://docs.ansible.com/ansible/latest/reference_appendices/config.html#callbacks-enabledappendparameter in theansible.builtin.usermodule takesgroups, notgroup; https://docs.ansible.com/ansible/latest/collections/ansible/builtin/user_module.html#parameter-appendTest Plan
Spin up
magma-devVM and check for warnings.Additional Information