Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agw): Pin Ansible version to fix installation [v1.7 backport] #13177

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix(agw): Pin Ansible version to fix installation [v1.7 backport] #13177

merged 1 commit into from
Jul 6, 2022

Conversation

sebathomas
Copy link
Contributor

Summary

Backporting code from #13158 to v1.7 branch. See #13164 for the backport to v1.6.

Test Plan

Release v1.7 was successfully installed with these changes as part of #13158.

Additional Information

  • This change is backwards-breaking

@sebathomas
fix(agw): Pin Ansible version to fix installation
b5028ee 
Ansible uses some of the same dependencies as Magma. This leads
to incompatibilities with pipelined for Ansible version >= 6
because they require different versions of Jinja2.

Cherry-picked from ef9cb06

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@sebathomas sebathomas requested a review from a team as a code owner July 4, 2022 11:07
@sebathomas sebathomas requested a review from ulaskozat July 4, 2022 11:07
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Jul 4, 2022
@sebathomas sebathomas changed the title fix(agw): Pin Ansible version to fix installation fix(agw): Pin Ansible version to fix installation [v1.7 backport] Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

feg-workflow

    2 files  202 suites   33s ⏱️
363 tests 363 ✔️ 0 💤 0 ❌
377 runs  377 ✔️ 0 💤 0 ❌

Results for commit b5028ee.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

agw-workflow

413 tests   403 ✔️  2m 5s ⏱️
    3 suites      9 💤
    3 files        1 ❌

For more details on these failures, see this check.

Results for commit b5028ee.

tmdzk
tmdzk approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@tmdzk tmdzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@tmdzk tmdzk merged commit 4e32e33 into magma:v1.7 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajahl ajahl ajahl approved these changes

@tmdzk tmdzk tmdzk approved these changes

@ulaskozat ulaskozat Awaiting requested review from ulaskozat ulaskozat is a code owner automatically assigned from magma/approvers-agw

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebathomas @ajahl @tmdzk