chore(agw): activate mypy code scanning for lte integ tests #13188

ajahl · 2022-07-05T08:20:25Z

Signed-off-by: Alex Jahl alexander.jahl@tngtech.com

Summary

The PR activates MyPy scanning for integ_tests in lte and fixes all MyPy related errors.
MyPy version 0.971 is used.

Test Plan

vagrant@magma$ cd $MAGMA_ROOT/lte/gateway
vagrant@magma$ mypy --ignore-missing-imports python/magma/

vagrant@magma$ bazel test //lte/gateway/python:all

Verified S1AP Integration Tests
Integ tests run successfully https://github.com/ajahl/magma/runs/7496395475?check_suite_focus=true

github-actions · 2022-07-05T08:20:42Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-07-05T08:28:51Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 5e38090.

♻️ This comment has been updated with latest results.

github-actions · 2022-07-05T08:51:20Z

dp-workflow

14 tests 14 ✔️ 2m 16s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 5e38090.

♻️ This comment has been updated with latest results.

github-actions · 2022-07-05T09:04:56Z

agw-workflow

615 tests 611 ✔️ 4m 14s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 5e38090.

♻️ This comment has been updated with latest results.

sebathomas

For the test plan, it would probably be good to run the integration tests either locally or on your fork. (Enable Github Actions, then run "LTE integ test" on the PR's branch.)

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

lte/gateway/python/integ_tests/common/service303_utils.py

nstng

pipelined changes LGTM

ajahl · 2022-07-25T13:13:35Z

For the test plan, it would probably be good to run the integration tests either locally or on your fork. (Enable Github Actions, then run "LTE integ test" on the PR's branch.)

Integ tests have passed https://github.com/ajahl/magma/runs/7496395475?check_suite_focus=true

ajahl · 2022-07-25T13:15:01Z

@magma/approvers-agw-integtests, can someone take a look at this PR? Thanks!

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

VinashakAnkitAman

Left a comment

ajahl · 2022-09-05T12:45:08Z

Hi @magma/approvers-agw-integtests, can someone take a look at this PR? Thanks!

VinashakAnkitAman

LGTM. Please rebase the code. One mandatory check is failing: dp-workflow / Domain proxy integration tests with orc8r (pull_request)

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

VinashakAnkitAman · 2022-09-26T18:13:22Z

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

-    # Default maximum wait time is 60 sec (1 min)
-    MAX_RESP_WAIT_TIME = 60
+    _msg: Queue = Queue()
+    # Default maximum wait time is 180 sec (3 min)


@ajahl Do we need this change or is any testcase failing because of the old max response timeout value of 60 seconds?

Yes, it makes the tests more stable.

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jul 5, 2022

github-actions bot added the component: agw Access gateway-related issue label Jul 5, 2022

ajahl marked this pull request as ready for review July 5, 2022 12:16

ajahl requested a review from a team July 5, 2022 12:16

ajahl requested a review from a team as a code owner July 5, 2022 12:16

ajahl requested review from rsarwad and ardzoht July 5, 2022 12:16

sebathomas reviewed Jul 5, 2022

View reviewed changes

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Outdated Show resolved Hide resolved

lte/gateway/python/integ_tests/common/service303_utils.py Outdated Show resolved Hide resolved

ajahl marked this pull request as draft July 5, 2022 15:36

ajahl force-pushed the activate_mypy_lte_integ_tests branch 4 times, most recently from b5d5cd6 to 4c334e3 Compare July 11, 2022 14:46

ajahl force-pushed the activate_mypy_lte_integ_tests branch from 4c334e3 to bdffc86 Compare July 18, 2022 14:11

ajahl marked this pull request as ready for review July 18, 2022 21:10

ajahl requested review from a team and koolzz July 18, 2022 21:10

nstng approved these changes Jul 20, 2022

View reviewed changes

ajahl force-pushed the activate_mypy_lte_integ_tests branch from bdffc86 to 6e74059 Compare July 25, 2022 08:43

Neudrino self-requested a review July 26, 2022 10:37

Neudrino approved these changes Jul 27, 2022

View reviewed changes

Neudrino requested review from pruthvihebbani, ssanadhya and VinashakAnkitAman July 27, 2022 17:54

ajahl force-pushed the activate_mypy_lte_integ_tests branch 2 times, most recently from e1e7ee7 to cab7f87 Compare July 28, 2022 07:05

VinashakAnkitAman reviewed Aug 18, 2022

View reviewed changes

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Show resolved Hide resolved

VinashakAnkitAman reviewed Aug 18, 2022

View reviewed changes

ajahl force-pushed the activate_mypy_lte_integ_tests branch from cab7f87 to de37795 Compare August 29, 2022 10:30

ajahl requested a review from VinashakAnkitAman September 1, 2022 08:07

ajahl enabled auto-merge (squash) September 2, 2022 09:25

VinashakAnkitAman approved these changes Sep 24, 2022

View reviewed changes

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Show resolved Hide resolved

VinashakAnkitAman reviewed Sep 26, 2022

View reviewed changes

chore(agw): activate mypy code scanning for lte integ tests

5e38090

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>

ajahl force-pushed the activate_mypy_lte_integ_tests branch from de37795 to 5e38090 Compare October 11, 2022 11:00

ajahl merged commit 28163f4 into magma:master Oct 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(agw): activate mypy code scanning for lte integ tests #13188

chore(agw): activate mypy code scanning for lte integ tests #13188

ajahl commented Jul 5, 2022 •

edited

github-actions bot commented Jul 5, 2022

github-actions bot commented Jul 5, 2022 •

edited

github-actions bot commented Jul 5, 2022 •

edited

github-actions bot commented Jul 5, 2022 •

edited

sebathomas left a comment

nstng left a comment

ajahl commented Jul 25, 2022

ajahl commented Jul 25, 2022 •

edited

VinashakAnkitAman left a comment

ajahl commented Sep 5, 2022 •

edited

VinashakAnkitAman left a comment •

edited

VinashakAnkitAman Sep 26, 2022 •

edited

ajahl Oct 11, 2022

chore(agw): activate mypy code scanning for lte integ tests #13188

chore(agw): activate mypy code scanning for lte integ tests #13188

Conversation

ajahl commented Jul 5, 2022 • edited

Summary

Test Plan

github-actions bot commented Jul 5, 2022

Howto

More info

github-actions bot commented Jul 5, 2022 • edited

feg-workflow

github-actions bot commented Jul 5, 2022 • edited

dp-workflow

github-actions bot commented Jul 5, 2022 • edited

agw-workflow

sebathomas left a comment

Choose a reason for hiding this comment

nstng left a comment

Choose a reason for hiding this comment

ajahl commented Jul 25, 2022

ajahl commented Jul 25, 2022 • edited

VinashakAnkitAman left a comment

Choose a reason for hiding this comment

ajahl commented Sep 5, 2022 • edited

VinashakAnkitAman left a comment • edited

Choose a reason for hiding this comment

VinashakAnkitAman Sep 26, 2022 • edited

Choose a reason for hiding this comment

ajahl Oct 11, 2022

Choose a reason for hiding this comment

ajahl commented Jul 5, 2022 •

edited

github-actions bot commented Jul 5, 2022 •

edited

github-actions bot commented Jul 5, 2022 •

edited

github-actions bot commented Jul 5, 2022 •

edited

ajahl commented Jul 25, 2022 •

edited

ajahl commented Sep 5, 2022 •

edited

VinashakAnkitAman left a comment •

edited

VinashakAnkitAman Sep 26, 2022 •

edited