feat(enodebd): BaiCells QRTB and FreedomFi One Carrier Aggregation #13195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
xbend
force-pushed
the
enodebd_qrtb_ffone_ca_support
branch
from
221027a
to
ca0338d
Compare
xbend
force-pushed
the
enodebd_qrtb_ffone_ca_support
branch
from
ca0338d
to
78c9a2f
Compare
github-actions
bot
removed
the
component: dp
xbend
force-pushed
the
enodebd_qrtb_ffone_ca_support
branch
2 times, most recently
from
6cc9f74
to
2318266
Compare
xbend
force-pushed
the
enodebd_qrtb_ffone_ca_support
branch
3 times, most recently
from
c4d3849
to
bf082c2
Compare
Added support for setting and configuring Carrier Aggregation on BaiCells QRTB and FreedomFi One based on state results received from Domain Proxy. Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>
xbend
force-pushed
the
enodebd_qrtb_ffone_ca_support
branch
from
bf082c2
to
c6d65cf
Compare
|
@magma/approvers-agw PR ready for review. Codecov complains due to mocking the entire python dp_client gRPC api call module. We tested this live. |
ajahl
approved these changes
Jul 7, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…agma#13195) Added support for setting and configuring Carrier Aggregation on BaiCells QRTB and FreedomFi One based on state results received from Domain Proxy. Signed-off-by: Artur Dębski <artur.debski@freedomfi.com> Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for setting and configuring Carrier Aggregation
on BaiCells QRTB and FreedomFi One based on state results received from
Domain Proxy:
enodebdmanages to ask for Domain Proxy state and acquire correct TX parameters)Signed-off-by: Artur Dębski artur.debski@freedomfi.com
Summary
Extended and modified BaiCells QRTB and FreedomFi One devices models in
enodebdto support Carrier Aggregation configuration based on Domain Proxy responses.Domain Proxy may obtain many LTE channel grants from SAS servers. As a result,
enodebddevice "drivers" will query Domain Proxy for CBSD state, and may receive a reply containing many LTE channels.If Domain Proxy response contains 2 or more channels, and explicitly enables carrier aggregation, Carrier Aggregation will be attempted to be configured on the respective eNBs.
In case Domain Proxy responses do no allow setting Carrier Aggregation (only 1 channel, carrier aggregation explicitly disabled),
enodebdwill reconfigure the eNB to parameters derived from the available channel and set eNB to work in Single Carrier mode - this behavior was suggested by both BaiCells (for eNBs running QRTB firmware) and Sercomm (for FreedomFi One Englewood and HGO)Test Plan
Extended unit testing for all supported scenarios.
Tested
enodebdcode contained in this PR with 1 BaiCells unit (Software Version: QRTB 2.8.15) and Sercomm Englewood (Software Version: RC3925@2204201602). Testing included simulations of Domain Proxy responses (0 channel response, 1 channel response, 2 channel response with CA-incompatible channels, 2 channels with CA-compatible channels) and verified transmission on each case.Additional Information
Domain Proxy does not yet implement obtaining multiple SAS grants for CBSDs. However the
enodebdgRPC API is already prepared as it returns aLTEChannelarray in the state response - but for the time being, the array will now only contain 1 channel, so the code will be "unused".Once Domain Proxy implementation finishes multiple grant support, the extra functionality in this PR will be fully utilized.