New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Amendments to AGW installation instructions #13198
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
c7f7e25
to
a9ea8cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of markdown lint errors.
Could we run the markdown --fix
on it?
I.e. probably the following locally (if you already have node installed):
sudo npm install --global markdownlint-cli
markdownlint --fix docs/readmes/lte/deploy_install.md
or alternatively try to do it in the respective container as indicated in the CI.
I'm confused as to why the Markdown lint check in the CI is passing then. Running |
a9ea8cb
to
6120ab7
Compare
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
6120ab7
to
561a70f
Compare
Hi @Neudrino, now that the linting has been fixed, could you please take another look at this? |
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Summary
Some minor changes to the Install Access Gateway on Ubuntu (Bare Metal) page that I made when reading through the instructions.
Test Plan
cd magma/docs && make precommit