chore(agw): adapt gateway_subscriber_state format

[alexzurbonsen]

Summary

To fix a deserializing error that occurred in an e2e test with agw integ tests, the outer array in the gateway_subscriber_state is removed.

Test Plan

Going back to the example from the original implementation, we basically change the following to make sure the entries for each IMSI exactly match the previous split subscriber_state:

{
    "subscribers": {
-        "IMSI001010000000002": [
+        "IMSI001010000000002": {
            {
                "magma.ipv4": [
                    {
                        "active_policy_rules": [
                            "{\"id\":\"allowlist_sid-IMSI001010000000002-magma.ipv4\",\"priority\":2,\"flowList\":[{\"match\":{}},{\"match\":{\"direction\":\"DOWNLINK\"}}],\"trackingType\":\"NO_TRACKING\"}"
                        ],
                        "active_duration_sec": 129,
                        "lifecycle_state": "SESSION_ACTIVE",
                        "session_start_time": 1654872554,
                        "apn": "magma.ipv4",
                        "ipv4": "192.168.128.13",
                        "msisdn": "",
                        "session_id": "IMSI001010000000002-320023"
                    }
                ]
            }
-        ],
-        "IMSI001010000000001": [
+        },
+        "IMSI001010000000001": {
            {
                "magma.ipv4": [
                    {
                        "active_policy_rules": [
                            "{\"id\":\"allowlist_sid-IMSI001010000000001-magma.ipv4\",\"priority\":2,\"flowList\":[{\"match\":{}},{\"match\":{\"direction\":\"DOWNLINK\"}}],\"trackingType\":\"NO_TRACKING\"}"
                        ],
                        "active_duration_sec": 129,
                        "lifecycle_state": "SESSION_ACTIVE",
                        "session_start_time": 1654872554,
                        "apn": "magma.ipv4",
                        "ipv4": "192.168.128.12",
                        "msisdn": "",
                        "session_id": "IMSI001010000000001-612699"
                    }
                ]
            }
-        ]
+        }
    }
}

Additional Information

• Done in pairing with @sebathomas.

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 75721db.

♻️ This comment has been updated with latest results.

[github-actions]

dp-workflow

18 tests   18 ✔️  5m 9s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit 75721db.

♻️ This comment has been updated with latest results.

[github-actions]

agw-workflow

580 tests   576 ✔️  4m 56s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 75721db.

♻️ This comment has been updated with latest results.

[sebathomas]

@magma/approvers-agw-sessiond Could someone take a look at this small PR if you get the chance? Thank you.

[themarwhal]

@magma/approvers-agw-sessiond Could someone take a look at this small PR if you get the chance? Thank you.

I'm not sure if we have any notifications set up for teams, so you might get a faster response if you tag directly in the future :)

[sebathomas]

@magma/approvers-agw-sessiond Could someone take a look at this small PR if you get the chance? Thank you.

I'm not sure if we have any notifications set up for teams, so you might get a faster response if you tag directly in the future :)

Good to know, and thank you for the review!