fix(agw): cpp migration of SPGW files #13213

pruthvihebbani · 2022-07-06T14:07:10Z

fix(agw): cpp migration of SPGW files

Summary

Migrated all the files under spgw task to cpp/hpp and fixed all the errors and warnings

Test Plan

Verified test_oai
Verified s1ap sanity suite

… warnings Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

github-actions · 2022-07-06T14:07:33Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

cpplint

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp|84| Using C-style cast. Use reinterpret_cast<SGWCauseMapping_t*>(...) instead [readability/casting] [4]
lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp|88| Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]
lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp|119| Using C-style cast. Use reinterpret_cast<mme_sgw_tunnel_t*>(...) instead [readability/casting] [4]
lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp|143| Using C-style cast. Use reinterpret_cast<s_plus_p_gw_eps_bearer_context_information_t*>(...) instead [readability/casting] [4]
lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp|250| Using C-style cast. Use reinterpret_cast<sgw_eps_bearer_ctxt_t*>(...) instead [readability/casting] [4]
lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp|993| Missing space before ( in if( [whitespace/parens] [5]
lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp|1124| Missing space before ( in if( [whitespace/parens] [5]
lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp|1489| Missing space before ( in if( [whitespace/parens] [5]
lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp|1714| Missing space before ( in if( [whitespace/parens] [5]
lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp|1794| Missing space before ( in if( [whitespace/parens] [5]

github-actions · 2022-07-06T14:09:39Z

lte/gateway/c/core/oai/tasks/sgw/pgw_handlers.cpp

    sgw_eps_bearer_context_information_t* sgw_ctxt_p,
    const itti_gx_nw_init_actv_bearer_request_t* const bearer_req_p,
    pdn_type_t pdn_type, uint32_t sgw_ip_address_S1u_S12_S4_up,
    struct in6_addr* sgw_ipv6_address_S1u_S12_S4_up, teid_t s1_u_sgw_fteid,
    uint32_t sequence_number, log_proto_t module) {
  OAILOG_FUNC_IN(module);
  sgw_eps_bearer_ctxt_t* eps_bearer_ctxt_p =
-      calloc(1, sizeof(sgw_eps_bearer_ctxt_t));
+      (sgw_eps_bearer_ctxt_t*)calloc(1, sizeof(sgw_eps_bearer_ctxt_t));


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<sgw_eps_bearer_ctxt_t*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:39Z

lte/gateway/c/core/oai/tasks/sgw/pgw_handlers.cpp

@@ -670,7 +676,8 @@
    }
  }
  struct sgw_eps_bearer_entry_wrapper_s* sgw_eps_bearer_entry_p =
-      calloc(1, sizeof(*sgw_eps_bearer_entry_p));
+      (sgw_eps_bearer_entry_wrapper_s*)calloc(1,


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<sgw_eps_bearer_entry_wrapper_s*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:39Z

lte/gateway/c/core/oai/tasks/sgw/pgw_procedures.cpp

@@ -53,19 +59,22 @@ void delete_pending_procedures(
 pgw_ni_cbr_proc_t* pgw_create_procedure_create_bearer(
    sgw_eps_bearer_context_information_t* ctx_p) {
  pgw_ni_cbr_proc_t* s11_proc_create_bearer =
-      calloc(1, sizeof(pgw_ni_cbr_proc_t));
+      (pgw_ni_cbr_proc_t*)calloc(1, sizeof(pgw_ni_cbr_proc_t));


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<pgw_ni_cbr_proc_t*>(...) instead [readability/casting] [4]

Please address lint warning

github-actions · 2022-07-06T14:09:40Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+#include "lte/gateway/c/core/oai/lib/3gpp/3gpp_29.274.h"
+
+static const SGWCauseMapping_t causes[] = {
+    {LOCAL_DETACH, (char*)"Local detach", 0, 0, 0, 0},


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:40Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+
+static const SGWCauseMapping_t causes[] = {
+    {LOCAL_DETACH, (char*)"Local detach", 0, 0, 0, 0},
+    {COMPLETE_DETACH, (char*)"Complete detach", 0, 0, 0, 0},


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:42Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+    {UE_NOT_RESPONDING, (char*)"UE not responding", 0, 1, 0, 0},
+    {SERVICE_DENIED, (char*)"Service Denied", 0, 0, 0, 0},
+    {UNABLE_TO_PAGE_UE, (char*)"Unable to page UE", 0, 1, 0, 0},
+    {NO_MEMORY_AVAILABLE, (char*)"No memory available", 1, 1, 1, 0},


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:42Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+    {SERVICE_DENIED, (char*)"Service Denied", 0, 0, 0, 0},
+    {UNABLE_TO_PAGE_UE, (char*)"Unable to page UE", 0, 1, 0, 0},
+    {NO_MEMORY_AVAILABLE, (char*)"No memory available", 1, 1, 1, 0},
+    {REQUEST_REJECTED, (char*)"Request rejected", 1, 1, 1, 0},


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:42Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+    {UNABLE_TO_PAGE_UE, (char*)"Unable to page UE", 0, 1, 0, 0},
+    {NO_MEMORY_AVAILABLE, (char*)"No memory available", 1, 1, 1, 0},
+    {REQUEST_REJECTED, (char*)"Request rejected", 1, 1, 1, 0},
+    {INVALID_PEER, (char*)"Invalid peer", 0, 0, 0, 1},


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:42Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+    {REQUEST_REJECTED, (char*)"Request rejected", 1, 1, 1, 0},
+    {INVALID_PEER, (char*)"Invalid peer", 0, 0, 0, 1},
+    {TEMP_REJECT_HO_IN_PROGRESS,
+     (char*)"Temporarily rejected due to HO in progress", 0, 0, 0, 0},


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:09:42Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+    {INVALID_PEER, (char*)"Invalid peer", 0, 0, 0, 1},
+    {TEMP_REJECT_HO_IN_PROGRESS,
+     (char*)"Temporarily rejected due to HO in progress", 0, 0, 0, 0},
+    {M_PDN_APN_NOT_ALLOWED, (char*)"Multiple PDN for a given APN not allowed",


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

github-actions · 2022-07-06T14:16:16Z

feg-workflow

    2 files 203 suites 39s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 75f2796.

♻️ This comment has been updated with latest results.

github-actions · 2022-07-06T14:26:50Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+
+  key.value = cause_value;
+  res =
+      (SGWCauseMapping_t*)bsearch((const void*)&key, causes, sizeof(causes),


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<SGWCauseMapping_t*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:26:50Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.cpp

+                                  sizeof(SGWCauseMapping_t), compare_cause_id);
+
+  if (res == NULL) {
+    return (char*)"Unknown cause";


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use const_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:26:50Z

lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp

@@ -110,7 +116,7 @@ mme_sgw_tunnel_t* sgw_cm_create_s11_tunnel(teid_t remote_teid,
 {
  mme_sgw_tunnel_t* new_tunnel = NULL;

-  new_tunnel = calloc(1, sizeof(mme_sgw_tunnel_t));
+  new_tunnel = (mme_sgw_tunnel_t*)calloc(1, sizeof(mme_sgw_tunnel_t));


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<mme_sgw_tunnel_t*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:26:51Z

lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp

@@ -134,7 +140,8 @@ sgw_cm_create_bearer_context_information_in_collection(teid_t teid) {
  s_plus_p_gw_eps_bearer_context_information_t* new_bearer_context_information =
      NULL;
  new_bearer_context_information =
-      calloc(1, sizeof(s_plus_p_gw_eps_bearer_context_information_t));
+      (s_plus_p_gw_eps_bearer_context_information_t*)calloc(


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<s_plus_p_gw_eps_bearer_context_information_t*>(...) instead [readability/casting] [4]

github-actions · 2022-07-06T14:26:51Z

lte/gateway/c/core/oai/tasks/sgw/sgw_context_manager.cpp

@@ -239,7 +246,8 @@ sgw_eps_bearer_ctxt_t* sgw_cm_create_eps_bearer_ctxt_in_collection(

  if (!sgw_pdn_connection
           ->sgw_eps_bearers_array[EBI_TO_INDEX(eps_bearer_idP)]) {
-    new_eps_bearer_entry = calloc(1, sizeof(sgw_eps_bearer_ctxt_t));
+    new_eps_bearer_entry =
+        (sgw_eps_bearer_ctxt_t*)calloc(1, sizeof(sgw_eps_bearer_ctxt_t));


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<sgw_eps_bearer_ctxt_t*>(...) instead [readability/casting] [4]

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

github-actions · 2022-07-06T14:51:03Z

dp-workflow

18 tests 18 ✔️ 4m 19s ⏱️
  2 suites   0 💤
  2 files   0 ❌

Results for commit 75f2796.

♻️ This comment has been updated with latest results.

github-actions · 2022-07-06T15:29:56Z

agw-workflow

615 tests 611 ✔️ 3m 58s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 75f2796.

♻️ This comment has been updated with latest results.

ssanadhya · 2022-07-06T18:09:07Z

lte/gateway/c/core/oai/tasks/sgw/s11_causes.c

@@ -1,89 +0,0 @@
-/*
- * Licensed to the OpenAirInterface (OAI) Software Alliance under one or more


Please move instead of deleting and re-adding

ssanadhya · 2022-07-06T18:09:22Z

lte/gateway/c/core/oai/tasks/sgw/pgw_procedures.cpp

@@ -53,19 +59,22 @@ void delete_pending_procedures(
 pgw_ni_cbr_proc_t* pgw_create_procedure_create_bearer(
    sgw_eps_bearer_context_information_t* ctx_p) {
  pgw_ni_cbr_proc_t* s11_proc_create_bearer =
-      calloc(1, sizeof(pgw_ni_cbr_proc_t));
+      (pgw_ni_cbr_proc_t*)calloc(1, sizeof(pgw_ni_cbr_proc_t));


Please address lint warning

ssanadhya · 2022-07-06T18:12:18Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.hpp

@@ -88,52 +94,41 @@ void populate_sgi_end_point_update(
    sgw_eps_bearer_ctxt_t* eps_bearer_ctxt_p,
    itti_sgi_update_end_point_response_t* sgi_update_end_point_resp);
 bool does_bearer_context_hold_valid_enb_ip(ip_address_t enb_ip_address_S1u);
-void populate_sgi_end_point_update(


Nice clean up!

ssanadhya · 2022-07-06T18:12:57Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.hpp

@@ -78,6 +81,9 @@ void sgw_populate_mbr_bearer_contexts_removed(
    const itti_sgi_update_end_point_response_t* const resp_pP, imsi64_t imsi64,
    sgw_eps_bearer_context_information_t* sgw_context_p,
    itti_s11_modify_bearer_response_t* modify_response_p);
+void sgw_process_release_access_bearer_request(


Move this function close to other release access bearer calls

ssanadhya · 2022-07-06T18:14:14Z

lte/gateway/c/core/oai/tasks/sgw/spgw_config.cpp

+#include "lte/gateway/c/core/common/dynamic_memory_check.h"
 #include "lte/gateway/c/core/common/assertions.h"


Sort alphabetically

Suggested change

#include "lte/gateway/c/core/common/dynamic_memory_check.h"

#include "lte/gateway/c/core/common/assertions.h"

#include "lte/gateway/c/core/common/assertions.h"

#include "lte/gateway/c/core/common/dynamic_memory_check.h"

ssanadhya · 2022-07-06T18:29:47Z

lte/gateway/c/core/oai/tasks/sgw/pgw_config.cpp

@@ -15,7 +15,7 @@
 *      contact@openairinterface.org
 */

-/*! \file spgw_config.c


Nice clean up!

ssanadhya · 2022-07-06T18:30:25Z

lte/gateway/c/core/oai/tasks/sgw/pgw_handlers.cpp

+#include "lte/gateway/c/core/oai/common/log.h"
+#include "lte/gateway/c/core/oai/lib/itti/intertask_interface.h"
+#include "lte/gateway/c/core/oai/lib/itti/intertask_interface_types.h"
+#include "lte/gateway/c/core/oai/lib/itti/itti_types.h"
 #include "lte/gateway/c/core/oai/common/common_types.h"
+#include "lte/gateway/c/core/common/dynamic_memory_check.h"
+#include "lte/gateway/c/core/oai/include/sgw_context_manager.h"
+extern void print_bearer_ids_helper(const ebi_t*, uint32_t);
+#ifdef __cplusplus


Please sort alphabetically

ssanadhya · 2022-07-06T18:34:01Z

lte/gateway/c/core/oai/tasks/sgw/pgw_handlers.cpp

    imsi64_t imsi64, uint8_t no_of_bearers_to_be_deact,
    ebi_t* ebi_to_be_deactivated, bool delete_default_bearer,
    teid_t mme_teid_S11, log_proto_t module) {
  OAILOG_FUNC_IN(module);
  MessageDef* message_p = itti_alloc_new_message(
-      module, S11_NW_INITIATED_DEACTIVATE_BEARER_REQUEST);


This function is used by both SPGW task and SGW_S8 task, so need to specify the right sender task based on the module parameter.

ssanadhya · 2022-07-06T18:34:32Z

lte/gateway/c/core/oai/tasks/sgw/pgw_handlers.cpp


-  message_p =
-      itti_alloc_new_message(module, S11_NW_INITIATED_ACTIVATE_BEARER_REQUEST);
+  message_p = itti_alloc_new_message(TASK_SPGW_APP,


Can we use the task name related to module ?

ssanadhya · 2022-07-06T18:35:26Z

lte/gateway/c/core/oai/tasks/sgw/sgw_paging.cpp

+#include "lte/gateway/c/core/oai/tasks/sgw/sgw_defs.hpp"
+#include "lte/gateway/c/core/oai/tasks/sgw/sgw_paging.hpp"


Can we also sort these alphabetically as part of this change?

LKreutzer · 2022-07-07T08:36:08Z

lte/gateway/c/core/oai/tasks/sgw/pgw_config.cpp

@@ -136,7 +143,7 @@ status_code_e pgw_config_process(pgw_config_t* config_pP) {
          OAILOG_CRITICAL(
              LOG_SPGW_APP,
              "ERROR in getting assigned IP block from mobilityd\n");
-          return -1;
+          return RETURNerror;


Nice catch! 👍

LKreutzer · 2022-07-07T08:40:36Z

lte/gateway/c/core/oai/tasks/sgw/pgw_handlers.cpp

    sgw_eps_bearer_context_information_t* sgw_ctxt_p,
    const itti_gx_nw_init_actv_bearer_request_t* const bearer_req_p,
    pdn_type_t pdn_type, uint32_t sgw_ip_address_S1u_S12_S4_up,
    struct in6_addr* sgw_ipv6_address_S1u_S12_S4_up, teid_t s1_u_sgw_fteid,
    uint32_t sequence_number, log_proto_t module) {
  OAILOG_FUNC_IN(module);
  sgw_eps_bearer_ctxt_t* eps_bearer_ctxt_p =
-      calloc(1, sizeof(sgw_eps_bearer_ctxt_t));
+      (sgw_eps_bearer_ctxt_t*)calloc(1, sizeof(sgw_eps_bearer_ctxt_t));


It would be great if we could fix all the C-style cast warnings as suggested

LKreutzer · 2022-07-07T08:42:12Z

lte/gateway/c/core/BUILD.bazel

-    "oai/tasks/sgw/sgw_defs.h",
-    "oai/tasks/sgw/sgw_handlers.h",
-    "oai/tasks/sgw/sgw_paging.h",
+    "oai/tasks/sgw/pgw_handlers.hpp",


Bazel changes lgtm, thanks for the clean up!

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

pruthvihebbani · 2022-07-08T14:15:35Z

In this PR I have moved files from c->cpp using mv command due to which the files are treated as new additions and the history is getting lost. Once this PR gets approved, I will close this and create a new PR where I will use git mv to rename the files. Rest of the changes will remain the same.

ssanadhya · 2022-07-08T16:13:25Z

In this PR I have moved files from c->cpp using mv command due to which the files are treated as new additions and the history is getting lost. Once this PR gets approved, I will close this and create a new PR where I will use git mv to rename the files. Rest of the changes will remain the same.

Only "s11_causes.c" is showing up as new addition. All other files, e.g. pgw_config.c->pgw_config.cpp, are showing as moved/renamed. So it should be possible to fix this one file in this PR itself. No need to duplicate effort by creating a new PR.

pruthvihebbani · 2022-07-08T16:22:15Z

In this PR I have moved files from c->cpp using mv command due to which the files are treated as new additions and the history is getting lost. Once this PR gets approved, I will close this and create a new PR where I will use git mv to rename the files. Rest of the changes will remain the same.

Only "s11_causes.c" is showing up as new addition. All other files, e.g. pgw_config.c->pgw_config.cpp, are showing as moved/renamed. So it should be possible to fix this one file in this PR itself. No need to duplicate effort by creating a new PR.

They show as renamed but git log does not show the full history of this file. For eg:

ssanadhya · 2022-07-08T16:35:07Z

In this PR I have moved files from c->cpp using mv command due to which the files are treated as new additions and the history is getting lost. Once this PR gets approved, I will close this and create a new PR where I will use git mv to rename the files. Rest of the changes will remain the same.

Only "s11_causes.c" is showing up as new addition. All other files, e.g. pgw_config.c->pgw_config.cpp, are showing as moved/renamed. So it should be possible to fix this one file in this PR itself. No need to duplicate effort by creating a new PR.

They show as renamed but git log does not show the full history of this file. For eg:

@pruthvihebbani , Please try git log --follow

pruthvihebbani · 2022-07-11T16:51:20Z

In this PR instead of git mv command mv command was used to rename the files. This was erasing the file commit history. Created a new PR #13264 to address this as modifying this PR was becoming messy

pruthvihebbani added 4 commits July 6, 2022 11:45

Converted sgw files from c to cpp and resolved compilation errors and…

9ed3476

… warnings Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

Reverted bazel file to resolve merge conflict

1766403

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

Merge remote-tracking branch 'upstream/master' into sgw_cpp_migration

53e2b03

Converted c files to cpp

ce7f4a6

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

pruthvihebbani requested review from a team, LKreutzer and ulaskozat July 6, 2022 14:07

pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label Jul 6, 2022

github-actions bot added the component: agw Access gateway-related issue label Jul 6, 2022

github-actions bot reviewed Jul 6, 2022

View reviewed changes

Fixed clang errors

f83d273

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

github-actions bot reviewed Jul 6, 2022

View reviewed changes

pruthvihebbani added 2 commits July 6, 2022 20:01

Fixed clang formatting

04f46d2

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

Merge remote-tracking branch 'upstream/master' into sgw_cpp_migration

dc9f656

ssanadhya requested changes Jul 6, 2022

View reviewed changes

LKreutzer approved these changes Jul 7, 2022

View reviewed changes

pruthvihebbani added 3 commits July 7, 2022 16:55

Addressed review comments

3ae3d24

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

Addressed review comments

f06ad24

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

Addressed review comments

75f2796

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>

pruthvihebbani mentioned this pull request Jul 11, 2022

fix(agw): cpp migration of SPGW files #13264

Merged

pruthvihebbani closed this Jul 11, 2022

		@@ -1,89 +0,0 @@
		/*
		* Licensed to the OpenAirInterface (OAI) Software Alliance under one or more

		#include "lte/gateway/c/core/common/dynamic_memory_check.h"
		#include "lte/gateway/c/core/common/assertions.h"

		#include "lte/gateway/c/core/oai/tasks/sgw/sgw_defs.hpp"
		#include "lte/gateway/c/core/oai/tasks/sgw/sgw_paging.hpp"

fix(agw): cpp migration of SPGW files #13213

fix(agw): cpp migration of SPGW files #13213

Conversation

pruthvihebbani commented Jul 6, 2022

Summary

Test Plan

github-actions bot commented Jul 6, 2022

Howto

More info

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot commented Jul 6, 2022 • edited

feg-workflow

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot Jul 6, 2022

Choose a reason for hiding this comment

github-actions bot commented Jul 6, 2022 • edited

dp-workflow

github-actions bot commented Jul 6, 2022 • edited

agw-workflow

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pruthvihebbani commented Jul 8, 2022

ssanadhya commented Jul 8, 2022

pruthvihebbani commented Jul 8, 2022

ssanadhya commented Jul 8, 2022

pruthvihebbani commented Jul 11, 2022

github-actions bot commented Jul 6, 2022 •

edited

github-actions bot commented Jul 6, 2022 •

edited

github-actions bot commented Jul 6, 2022 •

edited