fix(nms): Align read-me with markdown linter #13225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Neudrino
commented
Jul 7, 2022
Neudrino
commented
- Requires refactor(nms): Drop flow support and generated flow API #13208.
- No functional changes. Only formatting.
pull-request-size
bot
added
the
size/XXL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/readmes/nms/dev_testing.md
Outdated
| @@ -18,11 +18,11 @@ These are the set of tests that you should run before opening a pull request. | |||
|
|
|||
| #### Eslint | |||
|
|
|||
| Run `yarn run eslint` to test that there are no linter errors. You can also run `yarn run eslint --fix` to fix automatically fixable linter errors. | |||
| Run `yarn run eslint .` to test that there are no linter errors. You can also run `yarn run eslint --fix .` to fix automatically fixable linter errors. | |||
There was a problem hiding this comment.
[markdownlint] reported by reviewdog 🐶
MD013/line-length Line length [Expected: 80; Actual: 151]
Neudrino
force-pushed
the
nms/fix-markdownlint-errors
branch
from
db6a30b
to
2985859
Compare
pull-request-size
bot
added
size/S
github-actions
bot
removed
the
component: ci
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
as suggested in magma#13208 (comment) Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Neudrino
force-pushed
the
nms/fix-markdownlint-errors
branch
from
2985859
to
b645a49
Compare
thmsschmitt
approved these changes
Jul 11, 2022
voisey
approved these changes
Jul 11, 2022
talesmota
pushed a commit
to talesmota/magma
that referenced
this pull request
Jul 11, 2022
* fix(nms): Align read-me with markdown linter Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * docs: fix typo for nms as suggested in magma#13208 (comment) Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* fix(nms): Align read-me with markdown linter Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * docs: fix typo for nms as suggested in magma#13208 (comment) Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.