Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feg): Add APNResource data to S6a UL Answer #13236

Merged
merged 1 commit into from Jul 8, 2022

Conversation

emakeev
Copy link
Contributor

@emakeev emakeev commented Jul 7, 2022

Signed-off-by: Evgeniy Makeev evgeniym@fb.com

Summary

Add APNResource data to S6a UL Answer

Non-3GPP APN/Subscriber info in S6a ULA for use by EPS Auth clients.

Test Plan

Unit tests

Additional Information

  • This change is backwards-breaking

Signed-off-by: Evgeniy Makeev <evgeniym@fb.com>
@emakeev emakeev requested review from ssanadhya, pshelar, uri200, vroon2703 and a team July 7, 2022 22:17
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: feg FEG-gateway related issues label Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit c35f246.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

cloud-workflow

990 tests   990 ✔️  2m 10s ⏱️
355 suites      0 💤
    7 files        0

Results for commit c35f246.

Copy link
Collaborator

@ssanadhya ssanadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ssanadhya ssanadhya linked an issue Jul 8, 2022 that may be closed by this pull request
@emakeev emakeev merged commit fd886b4 into magma:master Jul 8, 2022
talesmota pushed a commit to talesmota/magma that referenced this pull request Jul 11, 2022
Signed-off-by: Evgeniy Makeev <evgeniym@fb.com>
@emakeev emakeev deleted the feg_proto_apn_resource branch August 5, 2022 23:09
emakeev added a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Evgeniy Makeev <evgeniym@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: feg FEG-gateway related issues size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AGW + Orc8r] Share APN specific per-UE config using S6a ULA
4 participants