feat(ci): add federated integ test for multi-ue to ci #13243
Conversation
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Semantic PR after the last commit. |
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
|
Please modify the documentation here https://docs.magmacore.org/docs/next/feg/s1ap_federated_test#s1ap-federated-integration-test if appropriate. Thanks! |
pull-request-size
bot
added
size/L
Hi @voisey Will you check my commit. I have updated the relevant mardown files. Do I update any other files ? |
There was a problem hiding this comment.
Could you please also update id and title fields of the docs, as well as the title of the page, to reflect that these are integ tests and no longer just a single test? E.g. "S1AP Federated Integration Test" -> "S1AP Federated Integration Tests". It might also be nice to update the second paragraph on the page, which starts "Currently, this test..." to briefly mention this new test as well?
docs/docusaurus/versioned_docs/version-1.7.0/feg/s1ap_federated_test.md
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/docusaurus/versioned_docs/version-1.7.0/feg/s1ap_federated_test.md
Outdated
Show resolved
Hide resolved
docs/docusaurus/versioned_docs/version-1.7.0/feg/s1ap_federated_test.md
Outdated
Show resolved
Hide resolved
pull-request-size
bot
added
size/M
pull-request-size
bot
added
size/L
|
Hi @voisey |
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Markdown lint check after the last commit. |
There was a problem hiding this comment.
Thanks for the update! I've added a few more comments now.
Also, now that the id and title have been updated, changes need to be made to a generated file, which the CI complains about here: https://github.com/magma/magma/runs/7296467848?check_suite_focus=true. Could you please run make -C $MAGMA_ROOT/docs, which should generate updates to $MAGMA_ROOT/docs/docusaurus/i18n/en.json, and then commit the changes to this file?
|
Hi @voisey |
lte/gateway/python/integ_tests/federated_tests/s1aptests/test_attach_detach_multi_ue.py
Outdated
Show resolved
Hide resolved
|
@voisey |
Signed-off-by: kharade <rohan.kharade@openairinterface.org>
Signed-off-by: kharade <rohan.kharade@openairinterface.org>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
|
@orion-belt Just fyi, Markdown lint check has been fixed by #13339, so if you rebase, it should pass |
|
Hi @uri200 @VinashakAnkitAman @ardzoht I have addressed comments of @voisey @Neudrino . |
Thanks @VinashakAnkitAman. I have merged master in my branch |
|
A clean rebase on master would be good here. |
* feat(ci): add federated integ test for multi-ue to ci Signed-off-by: kharade <rohan.kharade@openairinterface.org> * Documentation updated Signed-off-by: kharade <rohan.kharade@openairinterface.org> * feat(ci): Update FeG integ test documentation Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> Co-authored-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: kharade rohan.kharade@openairinterface.org
Summary
This PR adds Federated Integ Test for multi-ue to CI. This task is a modification of lte-integ-test.
Test Plan
Additional Information