refactor(nms): Fix some simple TypeScript migration TODOs #13247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
thmsschmitt
commented
Jul 8, 2022
| @@ -111,9 +111,6 @@ export default function CustomHistogram(props: Props) { | |||
| data={{datasets: props.dataset}} | |||
| options={{ | |||
| maintainAspectRatio: false, | |||
| // TODO[TS-migration is this a valid chart.js option?] | |||
| // @ts-ignore | |||
| scaleShowValues: true, | |||
There was a problem hiding this comment.
I searched through the code base of react-chart-js and chart-js and could not find "scaleShowValues".
thmsschmitt
commented
Jul 8, 2022
| // type WrapperVariant is a alias for: | ||
| // "dialog" | "inline" | "static" | ||
| // @ts-ignore | ||
| variant="outlined" |
There was a problem hiding this comment.
Test that this has no effect and inputVariant="outlined" is what is needed.
Neudrino
approved these changes
Jul 8, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
thmsschmitt
force-pushed
the
nms/fix-simple-ts-todos
branch
from
9de6fe3
to
0da116f
Compare
talesmota
pushed a commit
to talesmota/magma
that referenced
this pull request
Jul 11, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some simple TODOs from the TypeScript migration.