Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nms): Use networkIds from AppContext consistently #13256

Merged
merged 1 commit into from Jul 11, 2022

Conversation

thmsschmitt
Copy link
Contributor

Summary

Use networks ids from AppContext instead of duplicating the state three times.

Test Plan

  • Open the manage networks view.
  • Add a network
  • Make sure the network is shown in the manage network table and in the dropdown in the top bar
  • Remove a network
  • Make sure the network is no longer shown in the manage network table and in the dropdown
  • Add a network through the "Create Network" entry in the dropdown
  • Make sure the network is shown in both places

Screenshot 2022-07-11 at 09 01 01

Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jul 11, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jul 11, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b51ee9d.

@thmsschmitt thmsschmitt marked this pull request as ready for review July 11, 2022 07:20
@thmsschmitt thmsschmitt requested review from a team and HannaFar July 11, 2022 07:20
@thmsschmitt thmsschmitt merged commit 96387b2 into magma:master Jul 11, 2022
talesmota pushed a commit to talesmota/magma that referenced this pull request Jul 11, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants