Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): Only show policy placeholder if all tabs are empty #13262

Merged
merged 1 commit into from Jul 12, 2022

Conversation

thmsschmitt
Copy link
Contributor

@thmsschmitt thmsschmitt commented Jul 11, 2022

Summary

Show the Policy placeholder only if all tabs on the policy page are empty.

Test Plan

Follow the steps to reproduce in #13257. Make sure that the placeholder is only shown if nothing has been created.
Also verify that the placeholder reappears if all policy tabs become empty.

Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jul 11, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jul 11, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 0d6df93.

@github-actions
Copy link
Contributor

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 0d6df93.

@thmsschmitt thmsschmitt marked this pull request as ready for review July 11, 2022 15:45
@thmsschmitt thmsschmitt requested review from a team and andreilee July 11, 2022 15:45
@thmsschmitt thmsschmitt merged commit 3c37124 into magma:master Jul 12, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…3262)

Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NMS] Policy placeholder is not removed when creating base names, profiles or rating groups
2 participants