fix(dp): add max_ibw_mhz validation #13293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
hejjestemjarek
force-pushed
the
validate_max_ibw_mhz_value
branch
2 times, most recently
from
3595957
to
766d021
Compare
jkmar
reviewed
Jul 15, 2022
| @@ -21,6 +21,9 @@ definitions: | |||
| description: this is the maximum allowed difference in MHz between leftmost end of leftmost channel and rightmost end of rightmost channel used by a Base Station (eNB) | |||
| type: integer | |||
| x-nullable: false | |||
| maximum: 150 | |||
| minimum: 5 | |||
There was a problem hiding this comment.
Can we change it to 20, so that is it always greater than bandwidth of a single channel?
There was a problem hiding this comment.
Removed minimum: 5 from swagger validation, but modified MutableCbsd's ValidateModel func to ensure that max_ibw_mhz is not less than bandwidth_mhz.
hejjestemjarek
force-pushed
the
validate_max_ibw_mhz_value
branch
from
766d021
to
4398d00
Compare
jkmar
reviewed
Jul 15, 2022
| }, { | ||
| name: "Should validate max ibw mhz not multiple of 5", | ||
| data: b.NewMutableCbsdModelPayloadBuilder().WithMaxIbwMhz(7).Payload, | ||
| expectedError: "max_ibw_mhz in body should be a multiple of 5", |
There was a problem hiding this comment.
I would add a test for if m.Capabilities.MaxIbwMhz < m.FrequencyPreferences.BandwidthMhz and also for this !*m.GrantRedundancy && *m.CarrierAggregationEnabled, since I've noticed that it is missing for some reason
There was a problem hiding this comment.
Added them in a separate test, since original TestMutableCbsd_Validate covers only swagger generated Validate func and would not cover ValidateModel func.
pull-request-size
bot
added
size/L
jkmar
approved these changes
Jul 15, 2022
hejjestemjarek
force-pushed
the
validate_max_ibw_mhz_value
branch
from
bf6d418
to
24a766d
Compare
added 4 commits
July 18, 2022 14:09
Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com>
Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com>
Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com>
Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com>
hejjestemjarek
force-pushed
the
validate_max_ibw_mhz_value
branch
from
24a766d
to
167efa3
Compare
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
* fix(dp): add max_ibw_mhz validation Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com> * validate that max_ibw_mhz is not less than bandwidth_mhz Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com> * add MutableCbsd.ValidateModel tests Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com> * reorganize validation_test.go imports Signed-off-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com> Co-authored-by: Jarosław Jaszczuk <jaroslaw.jaszczuk@freedomfi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jarosław Jaszczuk jaroslaw.jaszczuk@freedomfi.com
Summary
Added validation for
max_ibw_mhzfield, that ensures the value is:>= 5<= 150Test Plan
Added test cases.
Additional Information