fix(dp): Add carrier aggregation fields to cbsd write fields #13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
jkmar
approved these changes
Jul 14, 2022
| @@ -205,15 +205,6 @@ func (b *DBCbsdBuilder) WithCbsdCategory(cat string) *DBCbsdBuilder { | |||
| return b | |||
| } | |||
|
|
|||
| // func (b *DBCbsdBuilder) WithDefaulValues() *DBCbsdBuilder { | |||
There was a problem hiding this comment.
How did it got merged in the first place?
| WithIndoorDeployment(false). | ||
| WithCarrierAggregationEnabled(true). | ||
| WithGrantRedundancy(true). | ||
| WithMaxIbwMhx(200).Cbsd) |
There was a problem hiding this comment.
200 is too big, max should be 150
| @@ -205,6 +219,9 @@ func (s *CbsdManagerTestSuite) TestUpdateCbsd() { | |||
| WithNumberOfPorts(cbsdBuilder.Cbsd.NumberOfPorts.Int64+4). | |||
| WithSingleStepEnabled(true). | |||
| WithIndoorDeployment(true). | |||
| WithCarrierAggregationEnabled(true). | |||
There was a problem hiding this comment.
it defaulted to false
Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com>
WojSad
force-pushed
the
carrier-aggregation-fields-missing
branch
from
5276d9e
to
08ef972
Compare
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…3296) Signed-off-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com> Co-authored-by: Wojciech Sadowy <wojciech.sadowy@freedomfi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wojciech Sadowy wojciech.sadowy@freedomfi.com
fix(dp): Add carrier aggregation fields to cbsd write fields