Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(orc8r): removes juju action create-orchestrator-admin-user #13308

Merged
merged 8 commits into from Aug 8, 2022

Conversation

saltiyazan
Copy link
Contributor

Summary

removes the juju action create-orchestrator-admin-user from the how-to guide as this action does not exist anymore.

saltiyazan and others added 4 commits July 8, 2022 07:43
fixes action name in the how-to guide for deploying with juju

Signed-off-by: saltiyazan <yazan.salti@canonical.com>
pull changes from upstream
removes the juju action create-orchestrator-admin-user from the how-to guide as this action does not exist anymore

Signed-off-by: saltiyazan <yazan.salti@canonical.com>
@saltiyazan saltiyazan requested review from a team and voisey July 15, 2022 09:36
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jul 15, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Jul 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 14b9d73.

♻️ This comment has been updated with latest results.

@voisey
Copy link
Contributor

voisey commented Jul 18, 2022

@gruyaume Could you please take a quick look at this to confirm this looks good, given you wrote this page?

@gruyaume
Copy link
Contributor

@gruyaume Could you please take a quick look at this to confirm this looks good, given you wrote this page?

Yes, let's just make sure that this PR is merged in the Charmed Magma project before this one here.

@voisey
Copy link
Contributor

voisey commented Jul 18, 2022

@gruyaume Okay, great. I'll set the DONOTLAND label for the moment but we can merge this once that's merged.

@voisey voisey added the DONOTLAND Please don't merge this label Jul 18, 2022
saltiyazan and others added 3 commits August 1, 2022 14:23
Pull upstream changes
Fixes deploy_using_juju how-to guide to use the new overlay.yaml and the updated commands

Signed-off-by: saltiyazan <yazan.salti@canonical.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 1, 2022
Signed-off-by: saltiyazan <yazan.salti@canonical.com>
@saltiyazan saltiyazan requested a review from voisey August 1, 2022 13:50
@saltiyazan
Copy link
Contributor Author

@Neudrino @voisey @gruyaume could you please merge the PR?

@Neudrino Neudrino merged commit c9fe601 into magma:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue DONOTLAND Please don't merge this size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants