Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amf): ICS IE not required for ICS #13318

Merged
merged 1 commit into from
Aug 28, 2022
Merged

fix(amf): ICS IE not required for ICS #13318

merged 1 commit into from
Aug 28, 2022

Conversation

Sathyaj27
Copy link
Contributor

Signed-off-by: Sathyaj27 sathya.jayadev@wavelabs.ai

Fix For #13306

Summary

-Removed check for ICS IE

Test Plan

  • Tested on spirent.

ICS

Additional Information

  • This change is not backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 18, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Jul 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@Sathyaj27 Sathyaj27 added type: bug Something isn't working and removed component: agw Access gateway-related issue labels Jul 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 10b224f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022 •
edited

dp-workflow

13 tests   13 ✔️  2m 51s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 10b224f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 54s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 10b224f.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jul 26, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Jul 26, 2022
@Sathyaj27 Sathyaj27 self-assigned this Jul 26, 2022
@Sathyaj27 Sathyaj27 marked this pull request as ready for review July 26, 2022 04:19
@Sathyaj27 Sathyaj27 requested review from a team and panyogesh July 26, 2022 04:19
pruthvihebbani
pruthvihebbani approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@pruthvihebbani pruthvihebbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sathyaj27
fix(amf): ICS IE not required for ICS
10b224f 
Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
panyogesh
panyogesh approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 145dfbe into magma:master Aug 28, 2022
@Sathyaj27 Sathyaj27 deleted the new branch September 1, 2022 01:50
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
@Sathyaj27 @rsarwad
fix(amf): ICS IE not required for ICS (magma#13318)
b116b9d 
Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>

Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
@panyogesh panyogesh mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruthvihebbani pruthvihebbani pruthvihebbani approved these changes

@panyogesh panyogesh panyogesh approved these changes

Assignees

@Sathyaj27 Sathyaj27

Labels
component: agw Access gateway-related issue product: 5g sa size/S Denotes a PR that changes 10-29 lines. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sathyaj27 @pruthvihebbani @panyogesh