New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(agw): Bazelify the session_state_5g_test #13326
Merged
LKreutzer
merged 1 commit into
magma:master
from
LKreutzer:bazelify_test_session_state_5g
Jul 19, 2022
Merged
chore(agw): Bazelify the session_state_5g_test #13326
LKreutzer
merged 1 commit into
magma:master
from
LKreutzer:bazelify_test_session_state_5g
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
LKreutzer
force-pushed
the
bazelify_test_session_state_5g
branch
from
July 18, 2022 14:26
a636123
to
8a03566
Compare
LKreutzer
force-pushed
the
bazelify_test_session_state_5g
branch
from
July 18, 2022 15:32
8a03566
to
cb84531
Compare
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
LKreutzer
force-pushed
the
bazelify_test_session_state_5g
branch
from
July 19, 2022 08:13
7ab3fc9
to
c14a6b4
Compare
1 task
jheidbrink
approved these changes
Jul 19, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bazel
changes for the Bazelification effort
component: agw
Access gateway-related issue
size/S
Denotes a PR that changes 10-29 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com
Summary
session_state_5g_test
is bazelifiedTest Plan
Bazel test checking for flakiness and with asan/lsan configs:
bazel test //lte/gateway/c/session_manager/test:session_state_5g_test --test_output=all --runs_per_test=100
bazel test //lte/gateway/c/session_manager/test:session_state_5g_test --test_output=all --config=asan
bazel test //lte/gateway/c/session_manager/test:session_state_5g_test --test_output=all --config=lsan
Additional Information
This is a partial fix for Remaining lte c/c++ tests are bazelified #12775
This change is backwards-breaking