Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): Bazelify the session_state_5g_test #13326

Merged
merged 1 commit into from Jul 19, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Jul 18, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • The session_state_5g_test is bazelified

Test Plan

Bazel test checking for flakiness and with asan/lsan configs:

  • bazel test //lte/gateway/c/session_manager/test:session_state_5g_test --test_output=all --runs_per_test=100
  • bazel test //lte/gateway/c/session_manager/test:session_state_5g_test --test_output=all --config=asan
  • bazel test //lte/gateway/c/session_manager/test:session_state_5g_test --test_output=all --config=lsan
  • CI

Additional Information

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jul 18, 2022
@LKreutzer LKreutzer self-assigned this Jul 18, 2022
@LKreutzer LKreutzer added the bazel changes for the Bazelification effort label Jul 18, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Jul 18, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit c14a6b4.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer force-pushed the bazelify_test_session_state_5g branch from a636123 to 8a03566 Compare July 18, 2022 14:26
@LKreutzer LKreutzer marked this pull request as ready for review July 18, 2022 14:28
@LKreutzer LKreutzer requested review from a team and jheidbrink July 18, 2022 14:28
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

dp-workflow

14 tests   14 ✔️  3m 29s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit c14a6b4.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer force-pushed the bazelify_test_session_state_5g branch from 8a03566 to cb84531 Compare July 18, 2022 15:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

agw-workflow

615 tests   611 ✔️  5m 13s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit c14a6b4.

♻️ This comment has been updated with latest results.

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer merged commit f82b07b into magma:master Jul 19, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants