fix(agw): Fixed cleanup for successful integ test #13332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
VinashakAnkitAman
requested review from
a team,
ulaskozat,
pruthvihebbani,
ardzoht and
rsarwad
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
pruthvihebbani
requested changes
Jul 25, 2022
lte/gateway/python/integ_tests/s1aptests/test_attach_detach_flaky_retry_success.py
Show resolved
Hide resolved
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
pull-request-size
bot
added
size/L
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
pruthvihebbani
requested changes
Aug 2, 2022
lte/gateway/python/integ_tests/s1aptests/test_attach_detach_flaky_retry_success.py
Outdated
Show resolved
Hide resolved
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
ardzoht
approved these changes
Aug 10, 2022
MagmaCIBot
pushed a commit
that referenced
this pull request
Aug 24, 2022
* fix(agw): Fixed cleanup for successful integ test Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> * Addressed flow rule verification for testcase Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> (cherry picked from commit 99cce40)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tmdzk
pushed a commit
that referenced
this pull request
Aug 24, 2022
* fix(agw): Fixed cleanup for successful integ test Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> * Addressed flow rule verification for testcase Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com> (cherry picked from commit 99cce40) Co-authored-by: Ankit Kumar Aman <50101753+VinashakAnkitAman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix(agw): Fixed cleanup for successful integ test
Summary
The TFW cleanup was added for the failing integ testcases as part of flaky retry support, but it was not done for successful test cases. While verifying flaky retry along with pytest, it as been observed that for some successful scenario also, while terminating the S1APTester these cleanups are needed for the next test case to run properly. This PR (a) adds the cleanup for successful test scenarios before closing (b) some minor formatting with pytest (c) adding one test case to validate cleanup by explicitely re-running the test case with flaky plugin for successful scenario (d) adding the test case as part of defs.mk file to run the test case as part of CI.
Test plan
Verified with sanity and in CI
Successful CI execution log:
https://github.com/VinashakAnkitAman/magma/runs/7397702222?check_suite_focus=true
Successful CI execution log after adding flow rule verification:
https://github.com/VinashakAnkitAman/magma/actions/runs/2736832846
Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com