Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): github runner for build_all is bumped from macos10.15 to 12 #13385

Merged
merged 1 commit into from Jul 22, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Jul 21, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

Context

Here

  • the build_all job is not using the trf server and can be bumped
  • we decided to use macos 12 because
    • its more recent
    • it already has vagrant and virtualbox pre-installed - the 11 image does not
  • I also took the liberty to add a workflow_dispatch trigger for easy testing
  • setup pyenv (gabrielfalcao/pyenv-action, with py 3.8.5) does not work with macos 11/12 - but it seems in a test run that it is not needed ... looks like tech debt -> removed

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng requested a review from a team as a code owner July 21, 2022 21:18
@nstng nstng requested a review from LKreutzer July 21, 2022 21:19
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 21, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jul 21, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 332fad5.

Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup pyenv (gabrielfalcao/pyenv-action, with py 3.8.5) does not work with macos 11/12 - but it seems in a test run that it is not needed ... looks like tech debt -> removed

Optional idea: If this is tech-depth, should we maybe create a ticket, to remove it from other setups as well?

@nstng
Copy link
Contributor Author

nstng commented Jul 22, 2022

Optional idea: If this is tech-depth, should we maybe create a ticket, to remove it from other setups as well?

imho an extra issue is not needed as this needs to be done when the other jobs are bumped to macos-12 (and also it will be checked there if the pyenv is needed in those jobs)

@nstng nstng merged commit c3732fd into magma:master Jul 22, 2022
MoritzThomasHuebner pushed a commit to MoritzThomasHuebner/magma that referenced this pull request Jul 26, 2022
magma#13385)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
magma#13385)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Github runners to macOS 12 due to deprecation of macOS 10.15
3 participants