Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove setup pyenv step from agw-workflow #13387

Merged
merged 1 commit into from Jul 22, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Jul 22, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • Remove unnecessary pyenv setup step in agw-workflow LTE test job
    • This saves ca. 2 min in the workflow

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jul 22, 2022
@LKreutzer LKreutzer self-assigned this Jul 22, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@LKreutzer LKreutzer marked this pull request as ready for review July 22, 2022 09:12
@LKreutzer LKreutzer requested a review from a team as a code owner July 22, 2022 09:12
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit a67a227.

@Neudrino Neudrino removed the request for review from mattymo July 22, 2022 10:00
@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 57s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit a67a227.

@LKreutzer LKreutzer merged commit 619ff25 into magma:master Jul 22, 2022
MoritzThomasHuebner pushed a commit to MoritzThomasHuebner/magma that referenced this pull request Jul 26, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants