Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dp): Remove grant attempts #13394

Merged
merged 1 commit into from Jul 25, 2022
Merged

feat(dp): Remove grant attempts #13394

merged 1 commit into from Jul 25, 2022

Conversation

jkmar
Copy link
Contributor

@jkmar jkmar commented Jul 22, 2022

Summary

Grant attemts have been obsolete since frequency preferences was introduced.

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

@pull-request-size pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label Jul 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue labels Jul 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022 •
edited

dp-workflow

14 tests   14 ✔️  3m 52s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 76dbfa4.

♻️ This comment has been updated with latest results.

xbend
xbend approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@xbend xbend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please rebase.

@jkmar
feat(dp): Remove grant attempts
76dbfa4 
Grant attemts have been obsolete since carrier aggregation was introduced.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
@jkmar jkmar marked this pull request as ready for review July 25, 2022 13:12
@jkmar jkmar requested review from a team and WojSad July 25, 2022 13:12
@jkmar jkmar merged commit cca60f1 into magma:master Jul 25, 2022
@jkmar jkmar deleted the remove_grant_attempts branch July 25, 2022 13:12
MoritzThomasHuebner pushed a commit to MoritzThomasHuebner/magma that referenced this pull request Jul 26, 2022
@jkmar @MoritzThomasHuebner
feat(dp): Remove grant attempts (magma#13394)
ac053b5 
Grant attemts have been obsolete since carrier aggregation was introduced.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@jkmar @emakeev
feat(dp): Remove grant attempts (magma#13394)
7b88212 
Grant attemts have been obsolete since carrier aggregation was introduced.

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xbend xbend xbend approved these changes

@WojSad WojSad Awaiting requested review from WojSad

Assignees
No one assigned
Labels
component: dp All updates to Domain Proxy dp module component: orc8r Orchestrator-related issue size/XL Denotes a Pull Request that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkmar @xbend