Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix slack notification on bazel LTE integ test failure #13395

Merged
merged 1 commit into from Jul 23, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Jul 22, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Jul 22, 2022
@LKreutzer LKreutzer self-assigned this Jul 22, 2022
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Jul 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 55281ed.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer marked this pull request as ready for review July 22, 2022 15:48
@LKreutzer LKreutzer requested a review from a team as a code owner July 22, 2022 15:48
@LKreutzer LKreutzer requested review from talkhasib and nstng and removed request for talkhasib July 22, 2022 15:48
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Jul 22, 2022
@LKreutzer LKreutzer merged commit ef758fb into magma:master Jul 23, 2022
MoritzThomasHuebner pushed a commit to MoritzThomasHuebner/magma that referenced this pull request Jul 26, 2022
…a#13395)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…a#13395)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) ready2merge This PR is ready to be merged (is approved and passes all required checks) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack notification on failure of bazel LTE integ test workflow should work
2 participants