feat(nms): Add new style to the Login page #13403
Conversation
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The NMS e2e test job is failing: https://github.com/magma/magma/runs/7498662277?check_suite_focus=true.
|
There are several warnings in the yarn test job about certain elements not used in the correct places. E.g. |
| @@ -55,6 +55,13 @@ const useStyles = makeStyles<Theme>(theme => ({ | |||
| fontWeight: 400, | |||
| marginLeft: '8px', | |||
| }, | |||
| label: { | |||
| fontSize: '14px', | |||
| fontFamily: 'Inter', | |||
There was a problem hiding this comment.
What is that fontFamily about?
There was a problem hiding this comment.
I looked a bit around and this is indeed a standard font that we use.
Although we typically use fontFamily: '"Inter", sans-serif',
This changes all labels across the app, but it does look better and it consistent with outer places so I'm fine with this change.
| padding: '0 24px', | ||
| }, | ||
| login: { | ||
| marginTop: '10%', | ||
| }, | ||
| title: { |
There was a problem hiding this comment.
This should be sufficient
There was a problem hiding this comment.
it was when I used the Grid component but now I need to keep most of it
There was a problem hiding this comment.
I see, this is because the title and subtitle are spans :|
HannaFar
force-pushed
the
nms/Login
branch
4 times, most recently
from
a089b66
to
444b135
Compare
They still appear in the last job. 🕵️ |
I fixed some errors that are unrelated to login here #13430 |
| @@ -55,6 +55,13 @@ const useStyles = makeStyles<Theme>(theme => ({ | |||
| fontWeight: 400, | |||
| marginLeft: '8px', | |||
| }, | |||
| label: { | |||
| fontSize: '14px', | |||
| fontFamily: 'Inter', | |||
There was a problem hiding this comment.
I looked a bit around and this is indeed a standard font that we use.
Although we typically use fontFamily: '"Inter", sans-serif',
This changes all labels across the app, but it does look better and it consistent with outer places so I'm fine with this change.
Signed-off-by: HannaFar <hannafarag159@gmail.com>
Signed-off-by: HannaFar <hannafarag159@gmail.com>
Signed-off-by: HannaFar hannafarag159@gmail.com
Summary
Add new style to the Login page
Organization portal sso enabled:
Organization portal:
Host portal:
Test Plan
Additional Information