Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nms): move FEG Gateway Add Button to equipment page #13410

Merged
merged 1 commit into from Jul 26, 2022
Merged

refactor(nms): move FEG Gateway Add Button to equipment page #13410

merged 1 commit into from Jul 26, 2022
+28 −419

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Jul 25, 2022 •
edited

Summary

Test Plan

grafik

Additional Information

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Jul 25, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022 •
edited

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f2ad7dd.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino marked this pull request as ready for review July 25, 2022 16:36
@Neudrino Neudrino requested a review from a team July 25, 2022 16:36
@Neudrino Neudrino marked this pull request as draft July 25, 2022 16:36
@Neudrino Neudrino marked this pull request as ready for review July 25, 2022 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022 •
edited

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f2ad7dd.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino force-pushed the nms/feg-gateway-edit-update branch from 9cdba4b to c058575 Compare July 25, 2022 16:59
thmsschmitt
thmsschmitt approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@thmsschmitt thmsschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left some minor comments.

nms/app/components/feg/FEGGatewayDialog.tsx Outdated Show resolved Hide resolved
nms/app/views/equipment/FEGEquipmentDashboard.tsx Outdated Show resolved Hide resolved
@Neudrino Neudrino force-pushed the nms/feg-gateway-edit-update branch from c058575 to cc632c1 Compare July 26, 2022 08:52
@Neudrino
refactor(nms): move FEG Gateway Add Button to equipment page
f2ad7dd 
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the nms/feg-gateway-edit-update branch from cc632c1 to f2ad7dd Compare July 26, 2022 08:52
@Neudrino Neudrino enabled auto-merge (squash) July 26, 2022 08:52
@Neudrino Neudrino merged commit 33c9797 into magma:master Jul 26, 2022
@Neudrino Neudrino deleted the nms/feg-gateway-edit-update branch July 26, 2022 10:01
MoritzThomasHuebner pushed a commit to MoritzThomasHuebner/magma that referenced this pull request Jul 26, 2022
@Neudrino @MoritzThomasHuebner
refactor(nms): move FEG Gateway Add Button to equipment page (magma#1…
fcca0de 
…3410)

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@Neudrino @emakeev
refactor(nms): move FEG Gateway Add Button to equipment page (magma#1…
615d14a 
…3410)

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsschmitt thmsschmitt thmsschmitt approved these changes

Assignees
No one assigned
Labels
component: nms NMS-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neudrino @thmsschmitt