New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Added initial build and upload workflow #13431
Merged
LKreutzer
merged 1 commit into
magma:master
from
MoritzThomasHuebner:build_and_upload_deb_workflow
Aug 5, 2022
Merged
feat(ci): Added initial build and upload workflow #13431
LKreutzer
merged 1 commit into
magma:master
from
MoritzThomasHuebner:build_and_upload_deb_workflow
Aug 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
label
Jul 27, 2022
MoritzThomasHuebner
force-pushed
the
build_and_upload_deb_workflow
branch
from
July 28, 2022 07:36
c3df975
to
4d5516c
Compare
MoritzThomasHuebner
force-pushed
the
build_and_upload_deb_workflow
branch
from
July 28, 2022 08:22
4d5516c
to
e4db918
Compare
Neudrino
reviewed
Jul 28, 2022
MoritzThomasHuebner
force-pushed
the
build_and_upload_deb_workflow
branch
from
August 3, 2022 06:56
d19125c
to
856e893
Compare
- Workflow builds nettle into a .deb file using fpm - Workflow installs nettle with the .deb to test if the .deb works - Extra check to see if the libnettle.so file exists - Upload artifact to github - Upload to artifactory The actor can configure: - The repository (default debian-test) - The distribution (default focal-ci) - Whether to do a try run, i.e. not actually upload the .deb (default true) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
MoritzThomasHuebner
force-pushed
the
build_and_upload_deb_workflow
branch
from
August 4, 2022 03:45
856e893
to
265823f
Compare
Neudrino
approved these changes
Aug 4, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
- Workflow builds nettle into a .deb file using fpm - Workflow installs nettle with the .deb to test if the .deb works - Extra check to see if the libnettle.so file exists - Upload artifact to github - Upload to artifactory The actor can configure: - The repository (default debian-test) - The distribution (default focal-ci) - Whether to do a try run, i.e. not actually upload the .deb (default true) Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
size/M
Denotes a PR that changes 30-99 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to #13450
Created in pairing with @alexzurbonsen
Summary
The actor can configure:
The magma repository probably still needs an access token for the artifactory. Currently, authentication works via username/password secrets.
Test Plan
Manually tested using the dry-run option. Also tested with a temporary folder on the artifactory (janheidbrink) with a temporary token:
https://artifactory.magmacore.org/ui/repos/tree/General/janheidbrink%2Fpool%2Ffocal-ci%2Foai-nettle_2.5-1ubuntu20.04_amd64.deb
Additional Information