Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Added initial build and upload workflow #13431

Merged

Conversation

MoritzThomasHuebner
Copy link
Contributor

@MoritzThomasHuebner MoritzThomasHuebner commented Jul 27, 2022

Relating to #13450

Created in pairing with @alexzurbonsen

Summary

  • Workflow builds nettle into a .deb file using fpm
  • Workflow installs nettle with the .deb to test if the .deb works
  • Extra check to see if the libnettle.so file exists
  • Upload artifact to github
  • Upload to artifactory
  • Access is currently restricted to a certain set of users.

The actor can configure:

  • The repository (default debian-test)
  • The distribution (default focal-ci)
  • Whether to do a try run, i.e. not actually upload the .deb (default true)

The magma repository probably still needs an access token for the artifactory. Currently, authentication works via username/password secrets.

Test Plan

Manually tested using the dry-run option. Also tested with a temporary folder on the artifactory (janheidbrink) with a temporary token:
https://artifactory.magmacore.org/ui/repos/tree/General/janheidbrink%2Fpool%2Ffocal-ci%2Foai-nettle_2.5-1ubuntu20.04_amd64.deb

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jul 27, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jul 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 265823f.

♻️ This comment has been updated with latest results.

@MoritzThomasHuebner MoritzThomasHuebner marked this pull request as ready for review July 28, 2022 07:40
@MoritzThomasHuebner MoritzThomasHuebner requested a review from a team as a code owner July 28, 2022 07:40
@Neudrino Neudrino requested review from Neudrino and removed request for jheidbrink July 28, 2022 11:01
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
.github/workflows/build_magma_dep.yml Outdated Show resolved Hide resolved
- Workflow builds nettle into a .deb file using fpm
- Workflow installs nettle with the .deb to test if the .deb works
- Extra check to see if the libnettle.so file exists
- Upload artifact to github
- Upload to artifactory

The actor can configure:
- The repository (default debian-test)
- The distribution (default focal-ci)
- Whether to do a try run, i.e. not actually upload the .deb (default true)

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
@LKreutzer LKreutzer merged commit 719a3c2 into magma:master Aug 5, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
- Workflow builds nettle into a .deb file using fpm
- Workflow installs nettle with the .deb to test if the .deb works
- Extra check to see if the libnettle.so file exists
- Upload artifact to github
- Upload to artifactory

The actor can configure:
- The repository (default debian-test)
- The distribution (default focal-ci)
- Whether to do a try run, i.e. not actually upload the .deb (default true)

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
@Neudrino Neudrino linked an issue Sep 13, 2022 that may be closed by this pull request
@MoritzThomasHuebner MoritzThomasHuebner deleted the build_and_upload_deb_workflow branch February 23, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CI to upload ONE deb artifact to JFrog Artifactory
3 participants