fix(nms): clean up node installation with make

[Neudrino]

Summary

The NMS setup for code generation was buggy and overly complex. Especially there were two different node versions installed at the same time, which lead to package conflicts.

Test Plan

• magma/orc/cloud$ make nms_fullgen
• magma/orc/cloud/docker$ ./build.py --generate
  • ✔️ https://github.com/magma/magma/runs/7581342542?check_suite_focus=true#step:5:1963

Additional Information

• Node JS automatically also installs npm.
• libgnutls30 is already installed on Ubuntu.
• Installing stuff with apt does not need extra linking into the bin folder.
• Noticed during testing of Investigate (and correct) Swagger type for networksNetworkIdRatingGroupsGet #13460.

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 439e622.

♻️ This comment has been updated with latest results.

[github-actions]

cloud-workflow

1 000 tests   1 000 ✔️  2m 17s ⏱️
   356 suites         0 💤
       7 files           0 ❌

Results for commit 439e622.

[github-actions]

dp-workflow

14 tests   14 ✔️  3m 52s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 439e622.

[github-actions]

agw-workflow

615 tests   611 ✔️  4m 30s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 439e622.

[sebathomas]

Looking good. 👍