Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amf): Adding Reject if Static ip configured is in subset of ip_pool #13472

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix(amf): Adding Reject if Static ip configured is in subset of ip_pool #13472

merged 1 commit into from
Sep 14, 2022

Conversation

Sathyaj27
Copy link
Contributor

@Sathyaj27 Sathyaj27 commented Aug 2, 2022 •
edited

Signed-off-by: Sathyaj27 sathya.jayadev@wavelabs.ai

Summary

When static ip is configured in subset of ip_pool reject should be handled instead of no response.

Test Plan

-Tested on UEransim
Rajeshsnew

4g Cases working fine. Ran s1ap integration test.
4G

Additional Information

  • This change is not backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 2, 2022
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 2, 2022
@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 2275edb.

♻️ This comment has been updated with latest results.

@Sathyaj27 Sathyaj27 closed this Aug 2, 2022
@Sathyaj27 Sathyaj27 reopened this Aug 2, 2022
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 2, 2022
@github-actions github-actions bot removed the component: orc8r Orchestrator-related issue label Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 56s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 2275edb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 50s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 2275edb.

♻️ This comment has been updated with latest results.

@Sathyaj27 Sathyaj27 added the type: bug Something isn't working label Aug 26, 2022
@Sathyaj27 Sathyaj27 marked this pull request as ready for review August 26, 2022 10:19
@Sathyaj27 Sathyaj27 requested a review from a team August 26, 2022 10:19
@Sathyaj27 Sathyaj27 requested a review from a team as a code owner August 26, 2022 10:19
@Sathyaj27 Sathyaj27 force-pushed the myfeature branch 2 times, most recently from 7a74b07 to 69d17a7 Compare August 30, 2022 06:55
@Sathyaj27 Sathyaj27 force-pushed the myfeature branch 2 times, most recently from 80cd9be to f8329e8 Compare September 9, 2022 09:57
@Sathyaj27
fix(amf): Adding Reject if Static ip configured is in subset of ip_pool
2275edb 
Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Sep 12, 2022
rsarwad
rsarwad approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@rsarwad rsarwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

panyogesh
panyogesh approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 0f9a6d3 into magma:master Sep 14, 2022
ajahl pushed a commit to ajahl/magma that referenced this pull request Sep 14, 2022
@Sathyaj27 @ajahl
fix(amf): Adding Reject if Static ip configured is in subset of ip_po…
db767f4 
…ol (magma#13472)

Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>

Signed-off-by: Sathyaj27 <sathya.jayadev@wavelabs.ai>
@Sathyaj27 Sathyaj27 deleted the myfeature branch September 27, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsarwad rsarwad rsarwad approved these changes

@panyogesh panyogesh panyogesh approved these changes

@Kaleem-Wavelabs Kaleem-Wavelabs Awaiting requested review from Kaleem-Wavelabs

@ssanadhya ssanadhya Awaiting requested review from ssanadhya ssanadhya was automatically assigned from magma/approvers-agw

@sebathomas sebathomas Awaiting requested review from sebathomas

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sathyaj27 @sebathomas @rsarwad @panyogesh