Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): reboot after dist upgrade in fabfile #13503

Merged
merged 1 commit into from
Aug 15, 2022
Merged

chore(ci): reboot after dist upgrade in fabfile #13503

merged 1 commit into from
Aug 15, 2022

Conversation

maxhbr
Copy link
Member

@maxhbr maxhbr commented Aug 4, 2022

Summary

fab does do a dist upgrade, but that only has full effect if there is a
reboot afterwards (e.g. to load new kernel modules).

Test Plan

tbd.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited

Oops! Looks like you failed the Python Format Check.

Howto

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit b636f83.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited

dp-workflow

15 tests   15 ✔️  4m 3s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b636f83.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 49s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit b636f83.

♻️ This comment has been updated with latest results.

@maxhbr maxhbr marked this pull request as ready for review August 9, 2022 18:04
@maxhbr maxhbr requested a review from a team as a code owner August 9, 2022 18:04
@maxhbr maxhbr requested a review from pshelar August 9, 2022 18:04
@sebathomas
Copy link
Contributor

Python formatting is wrong:
https://github.com/magma/magma/runs/7672630528?check_suite_focus=true

@maxhbr
chore(ci): reboot after dist upgrade in fabfile
b636f83 
fab does do a dist upgrade, but that only has full effect if there is a
reboot afterwards (e.g. to load new kernel modules).

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr maxhbr force-pushed the maxhbr/tryToRebootAfterDistUpgrade branch from 25959ec to b636f83 Compare August 10, 2022 07:59
@sebathomas
Copy link
Contributor

I think here it would be good to do an integration test run on your fork before the merge.

@maxhbr
Copy link
Member Author

maxhbr commented Aug 12, 2022 •
edited

I think here it would be good to do an integration test run on your fork before the merge.

I have done that before creation of the PR

@maxhbr maxhbr merged commit bde4c3e into magma:master Aug 15, 2022
maxhbr added a commit that referenced this pull request Aug 15, 2022
@maxhbr
Revert "chore(ci): reboot after dist upgrade in fabfile (#13503)"
ee56244 
This reverts commit bde4c3e.
@maxhbr maxhbr mentioned this pull request Aug 15, 2022
Merged
maxhbr added a commit that referenced this pull request Aug 15, 2022
@maxhbr
Revert "chore(ci): reboot after dist upgrade in fabfile (#13503)" (#1…
a6d6971 
…3615)

This reverts commit bde4c3e.

force merge this revert of a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebathomas sebathomas sebathomas approved these changes

@pshelar pshelar Awaiting requested review from pshelar pshelar was automatically assigned from magma/approvers-agw

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxhbr @sebathomas