Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused Bazel target eventd_cpp_proto #13513

Merged
merged 1 commit into from Aug 5, 2022

Conversation

vktng
Copy link
Contributor

@vktng vktng commented Aug 4, 2022

Signed-off-by: Krisztián Varga krisztian.varga@tngtech.com

Summary

We discovered in #13058 that the eventd_cpp_proto target is not needed by MME and it is not referenced anywhere else. This PR removes it.

Test Plan

CI.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
@vktng vktng added the bazel changes for the Bazelification effort label Aug 4, 2022
@vktng vktng requested a review from a team August 4, 2022 16:03
@vktng vktng self-assigned this Aug 4, 2022
@vktng vktng requested a review from LKreutzer August 4, 2022 16:03
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Aug 4, 2022
@vktng vktng linked an issue Aug 4, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 89c08bd.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

dp-workflow

14 tests   14 ✔️  3m 55s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 89c08bd.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

cloud-workflow

1 000 tests   1 000 ✔️  2m 13s ⏱️
   356 suites         0 💤
       7 files           0

Results for commit 89c08bd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

agw-workflow

615 tests   611 ✔️  4m 35s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 89c08bd.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the clean-up!

@nstng nstng merged commit 36585e1 into magma:master Aug 5, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Bazel target "eventd_cpp_proto" is not used anywhere
2 participants