chore: Allow Bazel commands to run in repository subdirectories #13523
Conversation
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vktng
force-pushed
the
fix_bazel_cannot_run_outside_magma_folder
branch
from
ece6839
to
4768d45
Compare
pull-request-size
bot
added
size/XS
.bazelrc
Outdated
| @@ -48,7 +48,7 @@ run:remote_caching_ro --remote_download_toplevel | |||
|
|
|||
| # Import the bazel caching config, with default disk cache, | |||
| # which in CI gets overwritten by the remote caching config. | |||
| import bazel/bazelrcs/cache.bazelrc | |||
| import /var/cache/cache.bazelrc | |||
There was a problem hiding this comment.
We could also use import %workspace%/bazel/bazelrcs/cache.bazelrc, see https://docs.bazel.build/versions/main/guide.html#imports
There was a problem hiding this comment.
This is a really clean solution, the other PR setting up symbolic links is not even needed.
There was a problem hiding this comment.
Is it possible to replace all links by %workspace%/.bazel-cache/ etc?
There was a problem hiding this comment.
I tried %workspace%/.bazel-cache/ and it works fine.
There was a problem hiding this comment.
Thanks, good to know. Then we might refactor the mechanics at some point to get rid of all the linking. But for now let us just keep it as it is as this is a larger refactoring.
There was a problem hiding this comment.
I stand corrected:
But it might work with a little more thought put into it.
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
vktng
force-pushed
the
fix_bazel_cannot_run_outside_magma_folder
branch
from
4768d45
to
265e881
Compare
Signed-off-by: Krisztián Varga krisztian.varga@tngtech.com
Summary
Since #12987 was merged, the bazel commands will only work in the magma folder, because the cache setup was reworked to use a relative path: bazel/bazelrcs/cache.bazelrc
This PR changes the path to use the workspace root.
Test Plan
Try using Bazel in subdirectories.
For example:
cd $MAGMA_ROOT/lte/gateway && bazel build //:buildifierAdditional Information