chore(orc8r): upload vagrant box with vagrant cli #13555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
maxhbr
force-pushed
the
maxhbr/uploadVagrantBoxWithVagrantCli
branch
from
7c48e44
to
5483346
Compare
maxhbr
commented
Aug 9, 2022
| "$VERSION" \ | ||
| "$BOX_PROVIDER" \ | ||
| "$BOX_FILE" \ | ||
| --release |
There was a problem hiding this comment.
this line will automatically release the file directly. Maybe we want to drop that, but that was also the old logic which was just broken.
maxhbr
changed the title
maxhbr
commented
Aug 15, 2022
|
|
||
| BOX_FILE=$1 | ||
|
|
||
| USER=magmacore | ||
| BOX=$(basename $BOX_FILE | cut -d_ -f1-2 | cut -d. -f1) | ||
| VERSION="1.1.$(date +"%Y%m%d")" | ||
| VERSION="1.2.$(date +"%Y%m%d")" |
There was a problem hiding this comment.
I thought we already bumped the version
There was a problem hiding this comment.
And this was changed on master too.
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
|
My changes, including tests: |
|
This might need a rebase, I think the broken dp integ test is fixed on master. |
|
I will rebase |
maxhbr
force-pushed
the
maxhbr/uploadVagrantBoxWithVagrantCli
branch
from
a392a73
to
b7fa204
Compare
sebathomas
reviewed
Aug 30, 2022
- Moved `--release` option to the beginning of `vagrant cloud publish`, suggested by `vagrant cloud publish --help` - Added a missing backslash - Tested script on personal vagrant account Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
MoritzThomasHuebner
force-pushed
the
maxhbr/uploadVagrantBoxWithVagrantCli
branch
from
b7fa204
to
01d0897
Compare
sebathomas
approved these changes
Aug 31, 2022
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
* chore(orc8r): upload vagrant box with vagrant cli Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com> * chore(orc8r): Tidied vagrant cli usage - Moved `--release` option to the beginning of `vagrant cloud publish`, suggested by `vagrant cloud publish --help` - Added a missing backslash - Tested script on personal vagrant account Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Co-authored-by: Moritz Huebner <moritz.huebner@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs someone to take care of it and to finish this PR.