Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Make it possible to manually start the Bazel build and test job #13567

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Aug 10, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • The workflow_dispatch trigger on the bazel workflow leads to a run of the bazel build and test job.
  • This does not apply to the package job (do we want that?) (added it there too)

Test Plan

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 10, 2022
@LKreutzer LKreutzer self-assigned this Aug 10, 2022
@LKreutzer LKreutzer linked an issue Aug 10, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit d45edff.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer marked this pull request as ready for review August 10, 2022 13:40
@LKreutzer LKreutzer requested a review from a team August 10, 2022 13:40
@LKreutzer LKreutzer added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Aug 11, 2022
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 16, 2022
@voisey
Copy link
Contributor

voisey commented Aug 16, 2022

@LKreutzer Just FYI, I think the ready2merge tag should only be added if the PR has been approved already, while I think this one is still waiting for someone from approvers-bazel.

@LKreutzer LKreutzer removed the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Aug 16, 2022
@LKreutzer
Copy link
Contributor Author

@LKreutzer Just FYI, I think the ready2merge tag should only be added if the PR has been approved already, while I think this one is still waiting for someone from approvers-bazel.

@voisey You are right, I removed it.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…t job

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer merged commit 0b19dff into magma:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow manual bazel workflow runs on magma/master
3 participants