Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use the bazel-built envoy_controller service in the LTE integ test bazel workflow #13585

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Aug 11, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

…teg test bazel workflow

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Aug 11, 2022
@LKreutzer LKreutzer self-assigned this Aug 11, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 11, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 11, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 90d34b9.

@LKreutzer LKreutzer marked this pull request as ready for review August 11, 2022 13:31
@LKreutzer LKreutzer requested review from a team as code owners August 11, 2022 13:31
@LKreutzer LKreutzer requested review from ssanadhya, mattymo and jheidbrink and removed request for mattymo August 11, 2022 13:31
@github-actions
Copy link
Contributor

dp-workflow

13 tests   13 ✔️  2m 56s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 90d34b9.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 48s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 90d34b9.

@LKreutzer LKreutzer requested review from sebathomas and removed request for ssanadhya August 11, 2022 14:35
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sebathomas sebathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LKreutzer LKreutzer merged commit de9bce4 into magma:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the bazel-built envoy_controller service in the bazel LTE integ tests
3 participants