Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): clean up the e2e test after execution #13586

Merged

Conversation

Neudrino
Copy link
Contributor

Summary

This cleanup should be best practice, as you will otherwise get errors during local execution due to not cleaned up network interfaces.

Test Plan

  • CI

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 11, 2022
@github-actions github-actions bot added the component: nms NMS-related issue label Aug 11, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 95edee5.

@Neudrino Neudrino marked this pull request as ready for review August 11, 2022 13:59
@Neudrino Neudrino requested review from a team, andreilee and thmsschmitt and removed request for andreilee August 11, 2022 13:59
@Neudrino Neudrino enabled auto-merge (squash) August 11, 2022 14:01
@Neudrino Neudrino self-assigned this Aug 11, 2022
@github-actions
Copy link
Contributor

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 95edee5.

@Neudrino Neudrino merged commit 1cdec39 into magma:master Aug 11, 2022
@Neudrino Neudrino deleted the nms/cleanup-e2e-test-setup-after-use branch August 11, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants