Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Moved setting up the hostname to ansible as reloading the vm would fail. #13622

Merged
merged 1 commit into from
Aug 17, 2022
Merged

fix(ci): Moved setting up the hostname to ansible as reloading the vm would fail. #13622

merged 1 commit into from
Aug 17, 2022

Conversation

crasu
Copy link
Contributor

@crasu crasu commented Aug 16, 2022 •
edited

Fixes #13618

Test Plan

Tested reloading locally:

  • magma_dev
  • magma_test
  • magma_trfserver

Feg test run

@crasu crasu requested a review from a team as a code owner August 16, 2022 09:12
@crasu crasu requested a review from pshelar August 16, 2022 09:12
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Aug 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022 •
edited

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit f27e01c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022 •
edited

dp-workflow

13 tests   13 ✔️  2m 17s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f27e01c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 50s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit f27e01c.

♻️ This comment has been updated with latest results.

@sebathomas
Copy link
Contributor

This needs a tag like fix(ci) or fix(agw) to pass the required checks.

fix(ci): Moved setting up the hostname to ansible as reloading the vm…
f27e01c 
… would fail.

The reason the reload failing is that some magma network devices do not fully come up
(e.g. do not get an ip even if set to auto).  This triggers this systemd/vagrant issue:
systemd/systemd#4733
fgrehm/vagrant-lxc#481

Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
@crasu crasu force-pushed the pr/move_hostname_setup_to_ansible branch from 9e24a3b to f27e01c Compare August 16, 2022 13:18
@crasu crasu changed the title Moved setting up the hostname to ansible as reloading the vm would fail. fix(ci): Moved setting up the hostname to ansible as reloading the vm would fail. Aug 17, 2022
@crasu crasu merged commit 77e75a8 into magma:master Aug 17, 2022
@mpfirrmann mpfirrmann mentioned this pull request Sep 27, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebathomas sebathomas sebathomas approved these changes

@pshelar pshelar Awaiting requested review from pshelar pshelar was automatically assigned from magma/approvers-agw

@mpfirrmann mpfirrmann Awaiting requested review from mpfirrmann

Assignees
No one assigned
Labels
component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WIP: (DEV)-VMs cannot be reloaded from vagrant
2 participants
@crasu @sebathomas