chore: new integ tests are bazelified

[nstng]

Summary

Main target here was to do #13588. But it came up that one python file - gpp_types.py - was not yet bazelified (this is used in integ tests, but somehow bazel has access on magma_test) and that there are three new integ tests that need to be bazelified.

Note that two of the integ tests seem to be setup and tear down "tests" for not yet activated ipv6 tests. But imho it is a good idea to bazelify them for now so that this logic is tested as well. The basilification of those tests was removed after a review discussion. This will be re-added when respective tests for these setup and teardown "tests" are added. Or they are included in the respective tests directly.

Test Plan

new tests

• ./bazel/scripts/run_integ_tests.sh lte/gateway/python/integ_tests/s1aptests:test_attach_detach_flaky_retry_success

gpp_types

On a vm != magma_test check if bazel run produces ModuleNotFound exceptions (the tests will fail! but the ModuleNotFound exception should come before the test failure). E.g., use

#!/usr/bin/env bash

LOGGING_FILE="/tmp/test_import_logging.log"

A=$(bazel query "kind(py_test, //lte/gateway/python/integ_tests/s1aptests/...)")
for test in $A
do
  echo "CHECKING ${test}"
  bazel run "${test}" --define=on_magma_test=1 2>&1  | tee "${LOGGING_FILE}"
  RESULT=$(grep -m 1 "ModuleNotFoundError" "${LOGGING_FILE}" || [[ $? == 1 ]])
  if [[ "${RESULT}" != "" ]];
  then
    exit 1
  fi
done

updated py files check

In bazel/scripts/check_py_bazel.sh remove line 56-81and check that the output corresponds to the removed lines. Note that some files are covered by excluding complete directories.

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 1b65ccc.

♻️ This comment has been updated with latest results.

[github-actions]

dp-workflow

13 tests   13 ✔️  1m 58s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 1b65ccc.

♻️ This comment has been updated with latest results.

[github-actions]

agw-workflow

615 tests   611 ✔️  3m 51s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 1b65ccc.

♻️ This comment has been updated with latest results.

[vktng]

We should add new tags to the file bazel/test_constants.bzl:

TAG_IPV6_TEST_ENABLE = ["ipv6_enable"] + TAG_MANUAL
TAG_IPV6_TEST_DISABLE = ["ipv6_disable"] + TAG_MANUAL

And tag the tests with these labels.
Even if it does not seem to break something, we should not run them out of order with the other precommit tests.

[nstng]

discussed offline - remove from BUILD.bazel and add to check again.

• these "tests" are for setup and do not test something currently
• we will ask the owner if this can be included in specific setup/teardown steps in tests (the two steps seem to be sufficiently fast)

[vktng]

LGTM