Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove xwf functionality from backend #13627

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

alexzurbonsen
Copy link
Contributor

@alexzurbonsen alexzurbonsen commented Aug 16, 2022

Summary

[Merge after #13603.]

Relates to #13546. This PR removes xwf functionality from backend (swagger interfaces). It is removed from front end in #13603.

Test Plan

  • CI
  • Check if xwf field is removed from swagger API (https://localhost:9443/swagger/v1/ui)
    Used endpoints, that do not require a gateway ID, to check. is_xwfm_variant disappeared in post method of /cwf and example models of various other endpoints.

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: cwf component: orc8r Orchestrator-related issue labels Aug 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

Oops! Looks like you failed the Semantic PR check.

Howto

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 14a858a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

dp-workflow

13 tests   13 ✔️  2m 2s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 14a858a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

cloud-workflow

1 009 tests   1 009 ✔️  2m 14s ⏱️
   356 suites         0 💤
       7 files           0

Results for commit 14a858a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

agw-workflow

615 tests   611 ✔️  3m 59s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 14a858a.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Aug 17, 2022
@github-actions github-actions bot added the component: nms NMS-related issue label Aug 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 14a858a.

♻️ This comment has been updated with latest results.

@alexzurbonsen alexzurbonsen marked this pull request as ready for review August 17, 2022 09:48
@alexzurbonsen alexzurbonsen requested review from a team, emakeev and crasu August 17, 2022 09:48
Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>
Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>
@alexzurbonsen alexzurbonsen merged commit e0d12a3 into magma:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: cwf component: nms NMS-related issue component: orc8r Orchestrator-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants