feat(agw): Run integ tests vs containerized AGW #13659

voisey · 2022-08-18T16:27:40Z

Summary

Works towards getting all integration tests running versus the containerized AGW, starting with test_attach_detach. Modifies system restarts to account for Docker. Also modifies the readme to explain the present situation and how to run the test, as well as adding sctpd to the services that need to be stopped before starting the Docker containers.

This aims to be a non-breaking PR which can be built upon in the future to get further tests running.

Test Plan

At present, test_attach_detach runs successfully if MAGMA_DEV_MODE is set to 1 in the .env file.

Notes:

In the future, we may want to use a Docker override file to set the required environment variable instead of modifying the .env file.
Containers can be started following the instructions here: https://github.com/magma/magma/blob/master/lte/gateway/docker/README.md#running-the-containerized-agw-locally-on-the-magma-vm.

github-actions · 2022-08-18T16:33:06Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-08-18T16:42:15Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 2242d2b.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-18T17:05:25Z

dp-workflow

13 tests 13 ✔️ 2m 6s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 2242d2b.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-18T17:32:11Z

agw-workflow

615 tests 611 ✔️ 3m 45s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 2242d2b.

♻️ This comment has been updated with latest results.

lte/gateway/docker/README.md

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

lte/gateway/docker/.env

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

jheidbrink

I confirmed that I can run test_attach_detach on this branch and it succeeds.

nstng · 2022-08-24T13:28:15Z

lte/gateway/docker/docker-compose.yaml

@@ -25,6 +25,7 @@ x-generic-service: &service
  logging: *logging_anchor
  restart: always
  network_mode: host
+  env_file: .env


might this line be redundant? is .env used by default?

The line was required to set the added environment variable in the containers, however the paths in .env were already being used in docker-compose.yaml as default. That said, this modification wasn't ideal so it has been replaced by the use of an override file, docker-compose.dev.yaml.

nstng

lgtm (modulo minor comment)

lte/gateway/docker/docker-compose.dev.yaml

sebathomas · 2022-08-26T06:51:44Z

Could someone from @magma/approvers-agw-integtests have a look at this PR? It's the first step for integration tests of the dockerized AGW.

rsarwad · 2022-08-26T08:16:35Z

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py

-        )
+        if self._init_system == InitMode.SYSTEMD:
+            self.exec_command(
+                "sudo service magma@* stop ; sudo service magma@magmad start",


Hi @sebathomas here it looks good as all services have restarted. Do we need similar handling for test case where an individual service have started. Say for test case, test_sctp_shutdown_while_mme_is_stopped.py mme, mobilityd, pipelined services have stopped and started mme service.
Please find the test case here, https://github.com/magma/magma/blob/master/lte/gateway/python/integ_tests/s1aptests/test_sctp_shutdown_while_mme_is_stopped.py

Thanks for looking into this. Yes, I expect more changes will be necessary to run all tests, this will be handled in the follow-up ticket #13684.

rsarwad

S1ap tester changes looks good to me

sebathomas · 2022-08-26T10:57:26Z

S1ap tester changes looks good to me

Can you approve the PR then? :)

rsarwad

s1ap changes LGTM

sebathomas · 2022-08-26T11:28:41Z

Thank you! I think the PR needs a rebase now because of changes to the semantic-pr CI, but apart from that it's ready to merge.

rsarwad · 2022-08-26T11:35:52Z

Thank you! I think the PR needs a rebase now because of changes to the semantic-pr CI, but apart from that it's ready to merge.
Yes

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 18, 2022

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch from 6b623a2 to fed0dcf Compare August 18, 2022 16:28

github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Aug 18, 2022

voisey linked an issue Aug 18, 2022 that may be closed by this pull request

Run integration test against containerized AGW #13475

Closed

5 tasks

wolfseb mentioned this pull request Aug 22, 2022

chore(agw): Python dependency upgrades #13482

Merged

1 task

voisey marked this pull request as ready for review August 22, 2022 08:38

voisey requested a review from a team August 22, 2022 08:38

voisey requested a review from a team as a code owner August 22, 2022 08:38

voisey requested review from a team, nstng, rsarwad and jheidbrink August 22, 2022 08:38

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch from fed0dcf to ae7bb8d Compare August 22, 2022 09:15

nstng reviewed Aug 22, 2022

View reviewed changes

jheidbrink reviewed Aug 22, 2022

View reviewed changes

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Outdated Show resolved Hide resolved

sebathomas reviewed Aug 22, 2022

View reviewed changes

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Outdated Show resolved Hide resolved

lte/gateway/python/integ_tests/s1aptests/s1ap_utils.py Outdated Show resolved Hide resolved

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch 3 times, most recently from deb8d6e to 7cf688e Compare August 22, 2022 14:57

sebathomas mentioned this pull request Aug 22, 2022

Fully test containerized AGW #13684

Closed

10 tasks

jheidbrink approved these changes Aug 23, 2022

View reviewed changes

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch 2 times, most recently from f7da167 to cf32c0b Compare August 24, 2022 12:50

voisey requested review from nstng and sebathomas August 24, 2022 12:52

sebathomas approved these changes Aug 24, 2022

View reviewed changes

nstng reviewed Aug 24, 2022

View reviewed changes

nstng approved these changes Aug 24, 2022

View reviewed changes

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch from cf32c0b to 89f0189 Compare August 24, 2022 15:48

pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Aug 24, 2022

github-actions bot reviewed Aug 24, 2022

View reviewed changes

lte/gateway/docker/docker-compose.dev.yaml Show resolved Hide resolved

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch 2 times, most recently from 8cbc576 to 030cff2 Compare August 24, 2022 15:51

crasu reviewed Aug 25, 2022

View reviewed changes

lte/gateway/docker/docker-compose.dev.yaml Show resolved Hide resolved

rsarwad reviewed Aug 26, 2022

View reviewed changes

rsarwad approved these changes Aug 26, 2022

View reviewed changes

feat(agw): Run integ tests versus containerized AGW

2242d2b

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>

voisey force-pushed the run-integ-tests-vs-dockerised-agw branch from 030cff2 to 2242d2b Compare August 26, 2022 12:04

voisey merged commit 7cdd7e9 into magma:master Aug 29, 2022

mpfirrmann mentioned this pull request Aug 29, 2022

feat(agw): All integ tests run vs dockerized agw #13766

Closed

7 tasks

rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022

feat(agw): Run integ tests versus containerized AGW (magma#13659)

ac8649a

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com> Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(agw): Run integ tests vs containerized AGW #13659

feat(agw): Run integ tests vs containerized AGW #13659

voisey commented Aug 18, 2022 •

edited

github-actions bot commented Aug 18, 2022

github-actions bot commented Aug 18, 2022 •

edited

github-actions bot commented Aug 18, 2022 •

edited

github-actions bot commented Aug 18, 2022 •

edited

jheidbrink left a comment

nstng Aug 24, 2022

voisey Aug 24, 2022

nstng left a comment

sebathomas commented Aug 26, 2022

rsarwad Aug 26, 2022

sebathomas Aug 26, 2022 •

edited

rsarwad left a comment

sebathomas commented Aug 26, 2022

rsarwad left a comment

sebathomas commented Aug 26, 2022

rsarwad commented Aug 26, 2022

feat(agw): Run integ tests vs containerized AGW #13659

feat(agw): Run integ tests vs containerized AGW #13659

Conversation

voisey commented Aug 18, 2022 • edited

Summary

Test Plan

github-actions bot commented Aug 18, 2022

Howto

More info

github-actions bot commented Aug 18, 2022 • edited

feg-workflow

github-actions bot commented Aug 18, 2022 • edited

dp-workflow

github-actions bot commented Aug 18, 2022 • edited

agw-workflow

jheidbrink left a comment

Choose a reason for hiding this comment

nstng Aug 24, 2022

Choose a reason for hiding this comment

voisey Aug 24, 2022

Choose a reason for hiding this comment

nstng left a comment

Choose a reason for hiding this comment

sebathomas commented Aug 26, 2022

rsarwad Aug 26, 2022

Choose a reason for hiding this comment

sebathomas Aug 26, 2022 • edited

Choose a reason for hiding this comment

rsarwad left a comment

Choose a reason for hiding this comment

sebathomas commented Aug 26, 2022

rsarwad left a comment

Choose a reason for hiding this comment

sebathomas commented Aug 26, 2022

rsarwad commented Aug 26, 2022

voisey commented Aug 18, 2022 •

edited

github-actions bot commented Aug 18, 2022 •

edited

github-actions bot commented Aug 18, 2022 •

edited

github-actions bot commented Aug 18, 2022 •

edited

sebathomas Aug 26, 2022 •

edited