Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deleted xwf path from ansible config #13677

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

sebathomas
Copy link
Contributor

Summary

Delete xwf roles_path entry in ansible config file of ocr8r_deployer.

Test Plan

  • Check whether deleted xwf roles are used in orc8r/cloud/deploy/orc8r_deployer/docker/root
    -> no, they are not
    Screenshot 2022-08-19 at 12 57 17

  • build and run orc8r_deployer container with run_deployer.bash. (Though ansible playbooks are only executed if cli commands like certs, install, update etc. are executed)

Additional Information

  • This change is backwards-breaking

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@sebathomas sebathomas requested a review from a team August 22, 2022 08:14
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Aug 22, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 6db5373.

@github-actions
Copy link
Contributor

dp-workflow

13 tests   13 ✔️  2m 0s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 6db5373.

@github-actions
Copy link
Contributor

cloud-workflow

1 009 tests   1 009 ✔️  2m 15s ⏱️
   356 suites         0 💤
       7 files           0

Results for commit 6db5373.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 44s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 6db5373.

@sebathomas sebathomas merged commit 6643815 into magma:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants